Skip to content

[15.0][FIX] document_page_reference: DeprecationWarning: Overriding 'resolve' #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jans23 wants to merge 7 commits into from
Closed

[15.0][FIX] document_page_reference: DeprecationWarning: Overriding 'resolve' #553

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9bbe983
fix DeprecationWarning: Overriding 'resolve'
jans23 Jul 27, 2025
f74bf47
fix unit tests
jans23 Jul 28, 2025
f0ef1bc
fix unit tests
jans23 Jul 28, 2025
71a2c9b
fix tests
jans23 Jul 28, 2025
5825662
fix pre-commit
jans23 Jul 28, 2025
69d8c46
fix pre-commit
jans23 Jul 28, 2025
c4e3e32
simpler fix
jans23 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions document_page_reference/models/document_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
name_re = re.compile("^%s$" % old_name_re.pattern)

class Context(SandboxedEnvironment.context_class):
def resolve(self, key):
res = super().resolve(key)
def resolve_or_missing(self, key):
res = super().resolve_or_missing(key)
if not isinstance(res, Undefined):
return res
return self.parent["ref"](key)
Expand Down Expand Up @@ -126,9 +126,10 @@ def get_content(self):
mako_env = mako_template_env
template = mako_env.from_string(tools.ustr(content))
return template.render(self._get_template_variables())
except Exception:
except Exception as e:
_logger.error(
"Template from page with id = %s cannot be processed" % self.id
"Template from page with id = %s cannot be processed: %s"
% (self.id, str(e))
)
return self.content

Expand Down
Loading