[17.0][MIG] document_page_tag_print_control: restrict document printing based on tag configuration #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BetoRaja
force-pushed
the
17.0-add-document_print_control
branch
2 times, most recently
from
4cc2c38 to
2c282c8
Compare
…ed on tag configuration
BetoRaja
force-pushed
the
17.0-add-document_print_control
branch
from
2c282c8 to
555c2c5
Compare
BetoRaja
changed the title
Jaimermaccione
approved these changes
Jul 30, 2025
Jaimermaccione
left a comment
Jaimermaccione
left a comment
There was a problem hiding this comment.
@BetoRaja LGTM! Functional review completed on Runboat.
Tested:
- Created tags and ensured the "not printable" option can be check on tags.
- Assigned both printable and non-printable tags across multiple pages.
- Verified that if at least one tag marked as "not printable" is assigned to a page, the page cannot be printed.
- Confirmed that users with the Manager role in Document Knowledge can print the page regardless of tag restrictions.
README file also appears complete and provides sufficient information to understand both the usage and configuration of the module.
Everything looks good!
|
@etobella what do u think? |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 2069762. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HaraldPanten @ValentinVinagre
Standard migration
T-5241