Skip to content

[16.0][IMP] Adicionado cadastro de Natureza Jurídica #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

renatonlima
Copy link
Member

Esse PR implementa do cadastro de natureza jurídica e também faz algumas mudanças na visão da empresa e adapta o módulo l10n_br_crm_cnpj_search substituindo o campo legal_nature pelo campo relacional legal_nature_id

image

No cadastro de empresa eu coloquei o grupo do CNAE e a natureza jurídica acima, pois essas seriam informações que deveriam ser preenchida antes dos campos de regime tributário e impostos pois futuramente podemos deduzir ou filtrar o preenchimento de outros campos, como no simples nacional.

@OCA-git-bot
Copy link
Contributor

Hi @rvalyi,
some modules you are maintaining are being modified, check this out!

@rvalyi rvalyi force-pushed the 16.0-l10n_br_fiscal-legal-nature branch from 57314cb to abdb0cb Compare May 9, 2025 22:42
@renatonlima renatonlima force-pushed the 16.0-l10n_br_fiscal-legal-nature branch 4 times, most recently from eec90b0 to aa734c2 Compare May 13, 2025 01:31
Copy link
Member

@mileo mileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

só não entendi a mudança de versão do spec ai no meio.

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<odoo>
<record model="ir.ui.view" id="crm_lead_cnpj_search_form_view">
<record model="ir.ui.view" id="crm_idad_cnpj_search_form_view">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta certo alterar o ID da view?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renatonlima faltou arrumar aqui tbm

column1="company_id",
column2="cnae_id",
domain="[('internal_type', '=', 'normal'), ('id', '!=', cnae_main_id)]",
string="Secondary CNAE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
string="Secondary CNAE",
string="Secondary CNAEs",

por ser um many2many acho que pode ser no plural aqui

@renatonlima renatonlima force-pushed the 16.0-l10n_br_fiscal-legal-nature branch from aa734c2 to f57216a Compare May 13, 2025 14:18
@renatonlima
Copy link
Member Author

@mileo

Eu fiz o rebase da branch agora só tem os commits no PR

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<odoo>
<record model="ir.ui.view" id="crm_lead_cnpj_search_form_view">
<record model="ir.ui.view" id="crm_idad_cnpj_search_form_view">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renatonlima faltou arrumar aqui tbm

@renatonlima renatonlima force-pushed the 16.0-l10n_br_fiscal-legal-nature branch from f57216a to c089ed4 Compare May 13, 2025 15:32
@rvalyi
Copy link
Member

rvalyi commented May 13, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3786-by-rvalyi-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6363d0f into OCA:16.0 May 13, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 13979dd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants