[14.0][FIX] l10n_it_split_payment: move lines are not correctly computed

l10n_it_split_payment/models/account_move.py

@@ -0,0 +1,76 @@
+# Copyright 2015  Davide Corio <davide.corio@abstract.it>
+# Copyright 2015-2016  Lorenzo Battistini - Agile Business Group
+# Copyright 2016  Alessio Gerace - Agile Business Group
+# Copyright 2023  Giuseppe Borruso <gborruso@dinamicheaziendali.it>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import Command, fields, models
+from odoo.tools import float_compare
+
+
+class AccountMove(models.Model):
+    _inherit = "account.move"
+
+    amount_sp = fields.Float(
+        string="Split Payment",
+        digits="Account",
+        store=True,
+        readonly=True,
+        compute="_compute_amount",
+    )
+    split_payment = fields.Boolean(
+        string="Is Split Payment", related="fiscal_position_id.split_payment"
+    )
+
+    def _compute_amount(self):
+        res = super()._compute_amount()
+        for move in self:
+            if move.split_payment:
+                if move.is_purchase_document():
+                    continue
+                if move.tax_totals:
+                    move.amount_sp = (
+                        move.tax_totals["amount_total"]
+                        - move.tax_totals["amount_untaxed"]
+                    )
+                    move.amount_residual -= move.amount_tax
+                    move.amount_tax = 0.0
+                else:
+                    move.amount_sp = 0.0
+                move.amount_total = move.amount_untaxed
+            else:
+                move.amount_sp = 0.0
+        return res
+
+    def write(self, vals):
+        res = super(AccountMove, self.with_context(check_move_validity=False)).write(
+            vals
+        )
+        if self.env.context.get("skip_split_payment_computation"):
+            return res
+        for move in self:
+            if move.split_payment:
+                line_sp = fields.first(
+                    move.line_ids.filtered(lambda move_line: move_line.is_split_payment)
+                )
+                for line in move.line_ids:
+                    if line.display_type == "tax" and not line.is_split_payment:
+                        write_off_line_vals = line._build_writeoff_line()
+                        if line_sp:
+                            if (
+                                float_compare(
+                                    line_sp.price_unit,
+                                    write_off_line_vals["price_unit"],
+                                    precision_rounding=move.currency_id.rounding,
+                                )
+                                != 0
+                            ):
+                                line_sp.write(write_off_line_vals)
+                        else:
+                            if move.amount_sp:
+                                move.with_context(
+                                    skip_split_payment_computation=True
+                                ).line_ids = [Command.create(write_off_line_vals)]
+        container = {"records": self}
+        self._check_balanced(container)
+        return res

l10n_it_split_payment/models/account_move_line.py

@@ -0,0 +1,67 @@
+# Copyright 2015  Davide Corio <davide.corio@abstract.it>
+# Copyright 2015-2016  Lorenzo Battistini - Agile Business Group
+# Copyright 2016  Alessio Gerace - Agile Business Group
+# Copyright 2023  Giuseppe Borruso <gborruso@dinamicheaziendali.it>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
+
+
+class AccountMoveLine(models.Model):
+    _inherit = "account.move.line"
+
+    is_split_payment = fields.Boolean(compute="_compute_is_split_payment", store=True)
+
+    @api.depends("account_id", "company_id.sp_account_id")
+    def _compute_is_split_payment(self):
+        for line in self:
+            line.is_split_payment = False
+            if line.account_id == line.company_id.sp_account_id:
+                line.is_split_payment = True
+
+    def _build_writeoff_line(self):
+        self.ensure_one()
+
+        if not self.move_id.company_id.sp_account_id:
+            raise UserError(
+                _(
+                    "Please set 'Split Payment Write-off Account' field in"
+                    " accounting configuration"
+                )
+            )
+        vals = {
+            "name": _("Split Payment Write Off"),
+            "partner_id": self.move_id.partner_id.id,
+            "account_id": self.move_id.company_id.sp_account_id.id,
+            "journal_id": self.move_id.journal_id.id,
+            "date": self.move_id.invoice_date,
+            "date_maturity": self.move_id.invoice_date,
+            "price_unit": -self.credit,
+            "amount_currency": self.credit,
+            "debit": self.credit,
+            "credit": self.debit,
+            "display_type": "tax",
+        }
+        if self.move_id.move_type == "out_refund":
+            vals["amount_currency"] = -self.debit
+            vals["debit"] = self.credit
+            vals["credit"] = self.debit
+        return vals
+
+    @api.model_create_multi
+    def create(self, vals_list):
+        lines = super().create(vals_list)
+        for line in lines:
+            if (
+                line.display_type == "tax"
+                and line.move_id.split_payment
+                and not line.is_split_payment
+                and not any(ml.is_split_payment for ml in line.move_id.line_ids)
+            ):
+                write_off_line_vals = line._build_writeoff_line()
+                line.move_id.line_ids = [(0, 0, write_off_line_vals)]
+                line.move_id._sync_dynamic_lines(
+                    container={"records": line.move_id, "self": line.move_id}
+                )
+        return lines