Skip to content

[14.0][FIX] l10n-italy: modules import fixes #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from

Conversation

Chionne27
Copy link

@Chionne27 Chionne27 commented May 26, 2025

This PR fixes imports in the asset_management and l10n_it_account_stamp modules

@Chionne27
Copy link
Author

Hi @sergiocorato and @matteoopenf I need to merge this PR that solves two import problems. Can you approve this PR and merge it?

@matteoopenf
Copy link
Contributor

Hi @sergiocorato and @matteoopenf I need to merge this PR that solves two import problems. Can you approve this PR and merge it?

Hi, which is the errore?

@Chionne27
Copy link
Author

Chionne27 commented May 26, 2025

Hi @sergiocorato and @matteoopenf I need to merge this PR that solves two import problems. Can you approve this PR and merge it?

Hi, which is the errore?

Hi, in a PR i have this error

2025-05-23 14:34:18,671 623 ERROR odoo odoo.tests.loader: Can not import assets_management.
Traceback (most recent call last):
File "/opt/odoo/odoo/tests/loader.py", line 29, in _get_tests_modules
mod = importlib.import_module('.tests', modpath)
File "/usr/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/__w/l10n-italy/l10n-italy/assets_management/tests/init.py", line 2, in
from . import test_assets_management
File "/__w/l10n-italy/l10n-italy/assets_management/tests/test_assets_management.py", line 10, in
from odoo.fields import Command, first
ImportError: cannot import name 'Command'

respectively in the other module

2025-05-23 14:34:18,666 623 ERROR odoo odoo.tests.loader: Can not import l10n_it_account_stamp.
Traceback (most recent call last):
File "/opt/odoo/odoo/tests/loader.py", line 29, in _get_tests_modules
mod = importlib.import_module('.tests', modpath)
File "/usr/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/__w/l10n-italy/l10n-italy/l10n_it_account_stamp/tests/init.py", line 5, in
from . import test_account_stamp_invoicing
File "/__w/l10n-italy/l10n-italy/l10n_it_account_stamp/tests/test_account_stamp_invoicing.py", line 2, in
from odoo.tools import first
ImportError: cannot import name 'first'

and someone suggested me to fix this in a separate PR

Copy link
Contributor

@matteoopenf matteoopenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants