[IMP] act_window conversion: don't replace plain string using re.sub#167
Open
hbrunn wants to merge 1 commit intoOCA:masterfrom
Open
[IMP] act_window conversion: don't replace plain string using re.sub#167hbrunn wants to merge 1 commit intoOCA:masterfrom
hbrunn wants to merge 1 commit intoOCA:masterfrom
Conversation
StefanRijnhart
approved these changes
Mar 2, 2026
sebalix
approved these changes
Apr 3, 2026
Contributor
|
This PR has the |
Member
|
/ocabot merge nobump |
Contributor
|
Sorry @yvaucher you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
Member
|
Oh, ok no rights on this repo. :-/ |
yvaucher
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
converting act_window tags will fail when the tag contains a domain, because
re.subexpects a regex, while we want to replace just the string