[19.0][MIG]: product_secondary_unit#2222
Open
JochenDeBie wants to merge 58 commits intoOCA:19.0from
Open
Conversation
…y unit for a product (OCA#377)
Currently translated at 100.0% (16 of 16 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_secondary_unit/es/
Currently translated at 100.0% (16 of 16 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_secondary_unit/fr/
…her models. TT27363
…en secondary uom changes [FIX] product_secondary_unit: Avoid cache missed
Co-authored-by: Hpar <raphael.reverdy@akretion.com>
Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_secondary_unit/es/
Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_secondary_unit/hr/
Currently translated at 95.6% (22 of 23 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_secondary_unit/tr/
Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_secondary_unit/ja/
Replace _get_factor_line() with uom._compute_quantity() to fix incorrect conversion when line UoM differs from product's base UoM. The previous method failed for certain UoM combinations (e.g., line in L, product in mL). Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
With the changes introduced in odoo/odoo@de056cc#diff-b37c7fd5520c97a29ddc59495779e7be61a66e15e85603928e27b3affb9dc31f, an error was occurring because the change validation on the model was being performed before tearDownClass was executed. Therefore, it has been modified so that the mock changes are applied in each test and cleaned up after each test. This way, the error will no longer appear and the test will run normally.
This was referenced Feb 25, 2026
JochenDeBie
changed the title
Member
|
/ocabot migration product_secondary_unit |
|
LGTM |
dreispt
approved these changes
Mar 27, 2026
Contributor
|
This PR has the |
BhaveshHeliconia
approved these changes
Mar 30, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Functional review LGTM!
Contributor
|
@OCA/product-maintainers Please, can you review/merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging it might be worth to check what is happening with #2211