Skip to content

[19.0][MIG] product_pricelist_fixed_currency_rate#2231

Open
JasminSForgeFlow wants to merge 16 commits intoOCA:19.0from
ForgeFlow:19.0-mig-product_pricelist_fixed_currency_rate
Open

[19.0][MIG] product_pricelist_fixed_currency_rate#2231
JasminSForgeFlow wants to merge 16 commits intoOCA:19.0from
ForgeFlow:19.0-mig-product_pricelist_fixed_currency_rate

Conversation

@JasminSForgeFlow
Copy link
Copy Markdown
Contributor

Standard Migration

@ForgeFlow

LoisRForgeFlow and others added 15 commits March 4, 2026 07:24
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/it/
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-18.0/product-attribute-18.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_pricelist_fixed_currency_rate/
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-18.0/product-attribute-18.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_pricelist_fixed_currency_rate/it/
@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

@JasminSForgeFlow can you include #2265 here? Thanks!

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

…doo 18

In Odoo 18, _compute_base_price() parameter was renamed from
'target_currency' to 'currency'. The old signature causes:
TypeError: ProductPricelist._compute_base_price() got an unexpected
keyword argument 'currency'

Fix: rename parameter to 'currency' to match parent method signature.

Closes: OCA#1831
@OCA-git-bot OCA-git-bot added series:19.0 mod:product_pricelist_fixed_currency_rate Module product_pricelist_fixed_currency_rate labels Apr 30, 2026
@JasminSForgeFlow
Copy link
Copy Markdown
Contributor Author

@JasminSForgeFlow can you include #2265 here? Thanks!

Added, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:product_pricelist_fixed_currency_rate Module product_pricelist_fixed_currency_rate series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants