[14.0][IMP] product_logistics_uom: Length UoM to Settings View#2261
Open
raumschmiede-joshuaL wants to merge 1 commit intoOCA:14.0from
Open
[14.0][IMP] product_logistics_uom: Length UoM to Settings View#2261raumschmiede-joshuaL wants to merge 1 commit intoOCA:14.0from
raumschmiede-joshuaL wants to merge 1 commit intoOCA:14.0from
Conversation
Contributor
|
Hi @hparfr, |
OCA-git-bot
added
mod:product_logistics_uom
Author
Author
|
Will create a PR soon to fix the pre-commit problem. EDIT |
raumschmiede-joshuaL
force-pushed
the
14.0-log_uom-length-uom-view
branch
from
ab3f788 to
ccd2122
Compare
mt-software-de
suggested changes
Apr 22, 2026
mt-software-de
left a comment
mt-software-de
left a comment
There was a problem hiding this comment.
Thx. Please split the commit.
There was a problem hiding this comment.
You should do a cherry-pick. b112ece#diff-ee9090ad2f93bb9e5f5005222971731fe1dae5ca5eb20f9698bb752562a5b048
including only the new field added to the view.
And then an separate commit for formatting the file.
Author
There was a problem hiding this comment.
Eventhough the commit's name is not related to the change as it is a whole module migration?
After that I would need to add a fix commit to make the change work with version 14.0.
And as last commit the one to format the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In later versions the field already exists in the settings view. I added it to the 14.0:
Code had one intendation too much. I removed it so that the pre-commit changes look better. pre-commit does not re-indent the XML tags, only the attributes