Skip to content

[19.0][MIG] product_state_sale: Migration to 19.0#2275

Open
MohamedOsman7 wants to merge 4 commits intoOCA:19.0from
c4a8-odoo:19.0-mig_product_state_sale
Open

[19.0][MIG] product_state_sale: Migration to 19.0#2275
MohamedOsman7 wants to merge 4 commits intoOCA:19.0from
c4a8-odoo:19.0-mig_product_state_sale

Conversation

@MohamedOsman7
Copy link
Copy Markdown
Contributor

@MohamedOsman7 MohamedOsman7 commented Apr 29, 2026

supersede: #2203
Depends on product_state: #2217 (Merged !)

@OCA-git-bot OCA-git-bot added series:19.0 mod:product_state_sale Module product_state_sale labels Apr 29, 2026
@MohamedOsman7 MohamedOsman7 mentioned this pull request Apr 29, 2026
73 tasks
Copy link
Copy Markdown

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but these should be squashed:

Image

Comment on lines +3 to +4
- [Apik](https://apik.cloud):
- Thomas HERBIN \<<the@apik.cloud>\>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed... migration without changes is not contrebuting

<record id="sales_team.group_sale_manager" model="res.groups">
<field
name="implied_ids"
eval="[(4, ref('product_state.group_product_state_manager'))]"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eval="[(4, ref('product_state.group_product_state_manager'))]"
eval="[Command.link(ref('product_state.group_product_state_manager'))]"

@MohamedOsman7 MohamedOsman7 force-pushed the 19.0-mig_product_state_sale branch from d373405 to 99b48a7 Compare April 29, 2026 12:46
@MohamedOsman7 MohamedOsman7 force-pushed the 19.0-mig_product_state_sale branch from 99b48a7 to a406451 Compare April 29, 2026 12:48
@MohamedOsman7 MohamedOsman7 requested a review from CRogos April 29, 2026 12:48
@MohamedOsman7
Copy link
Copy Markdown
Contributor Author

@BhaveshHeliconia can you please make a review

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered an error.

Apps.mp4

@MohamedOsman7
Copy link
Copy Markdown
Contributor Author

MohamedOsman7 commented Apr 30, 2026

I encountered an error.

Apps.mp4

I solved it here #2278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:product_state_sale Module product_state_sale series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants