[FIX] sale_product_pack: _get_update_prices_lines refactor #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @ernestotejeda, |
Contributor
|
Please @jue-adhoc add steps to reproduce the error! |
Author
steps added! thanks @augusto-weiss |
Co-authored-by: augusto-weiss <90717087+augusto-weiss@users.noreply.github.com>
jue-adhoc
force-pushed
the
16.0-h-82779-jue
branch
from
2f56e1c to
af9db8e
Compare
Contributor
|
LGTM |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created because we found and issue when changing the pricelist on packs that have been modified. When an user modifies some of the components of the pack, the index calculated on the _get_update_prices_lines remains with a previous value and the price is not updated correctly (the last line on the pack is not updated).
We based our refactor on this PR made a few weeks ago on version 17 which resolves another issues apart from this one and it is already reviewed and merged.
Steps to reproduce the error:
Result: the pack should change the price of every component, but the last order line will not be updated due to a difference in the index inside the while loop (it would not take into account the last item).