Skip to content

Conversation

@antonyht27
Copy link

No description provided.

@antonyht27 antonyht27 mentioned this pull request Dec 1, 2025
6 tasks
@antonyht27 antonyht27 changed the title [MIG] purchase_product_pack: Migration to 17.0 [17.0][MIG] purchase_product_pack: Migration to 17.0 Dec 1, 2025
@antonyht27 antonyht27 force-pushed the 17.0-mig-purchase_product_pack branch from 3728e5f to b4c17ab Compare December 2, 2025 08:55
@antonyht27 antonyht27 force-pushed the 17.0-mig-purchase_product_pack branch from cb60ad1 to a6e988d Compare December 2, 2025 11:05
Copy link

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to preserve the commit history during migration following the guides:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch
You can check how it should look in the 18.0 migration https://github.com/OCA/product-pack/pull/216/commits

@antonyht27 antonyht27 force-pushed the 17.0-mig-purchase_product_pack branch from a6e988d to fe70f09 Compare December 2, 2025 16:18
@antonyht27
Copy link
Author

Is this how it should look? @christian-ramos-tecnativa

I don't quite understand; last time I only wanted a single commit.

Copy link

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@smcqueen81 smcqueen81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok functional.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants