-
-
Notifications
You must be signed in to change notification settings - Fork 143
[17.0][MIG] purchase_product_pack: Migration to 17.0 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
3728e5f to
b4c17ab
Compare
cb60ad1 to
a6e988d
Compare
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to preserve the commit history during migration following the guides:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch
You can check how it should look in the 18.0 migration https://github.com/OCA/product-pack/pull/216/commits
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-16.0/product-pack-16.0-purchase_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-purchase_product_pack/it/
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-16.0/product-pack-16.0-purchase_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-purchase_product_pack/pt/
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-16.0/product-pack-16.0-purchase_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-purchase_product_pack/it/
a6e988d to
fe70f09
Compare
|
Is this how it should look? @christian-ramos-tecnativa I don't quite understand; last time I only wanted a single commit. |
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
smcqueen81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok functional.
LGTM
|
This PR has the |
No description provided.