Skip to content

[16.0] [IMP] purchase_discount: apply default discount when no seller found #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Borruso wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0] [IMP] purchase_discount: apply default discount when no seller found #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions purchase_discount/models/purchase_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,7 @@ def _compute_price_unit_and_date_planned_and_name(self):
def _apply_value_from_seller(self, seller):
"""Overload this function to prepare other data from seller,
like in purchase_triple_discount module"""
if not seller:
return
self.discount = seller.discount
self.discount = seller.discount or self.partner_id.default_supplierinfo_discount

def _prepare_account_move_line(self, move=False):
vals = super()._prepare_account_move_line(move)
Expand Down Expand Up @@ -119,9 +117,9 @@ def _prepare_purchase_order_line(
def _prepare_purchase_order_line_from_seller(self, seller):
"""Overload this function to prepare other data from seller,
like in purchase_triple_discount module"""
if not seller:
return {}
return {"discount": seller.discount}
return {
"discount": seller.discount or self.partner_id.default_supplierinfo_discount
}

def write(self, vals):
res = super().write(vals)
Expand Down