[18.0][FIX] purchase_order_secondary_unit: revert report features requiring unmerged dependency#2953
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Feb 16, 2026
Conversation
… unmerged dependency Partially revert a1eea87 for purchase order and quotation report templates. The reverted portions rely on methods (hide_secondary_uom_column, get_secondary_uom_display_mode) introduced by OCA/product-attribute#2211, which is not yet merged. Without that dependency, the reports would crash when printing. The secondary quantity column is kept but the conditional visibility and display mode logic are removed until the dependency is available.
This was referenced Feb 16, 2026
pedrobaeza
approved these changes
Feb 16, 2026
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Let's fast track it for fixing the situation
/ocabot merge patch
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 30fbba4. Thanks a lot for contributing to OCA. ❤️ |
|
@yostashiro Is it possible the changes made to the portal template here a1eea87#diff-88648ec43d7bc467356eb6a30b89ae0be9e11574ed6d50316772d2a7dae8d50c should also still be reverted? The reverted methods (report_show_price_uom, hide_secondary_uom_column, get_secondary_uom_display_mode, ) are also used in here. |
Contributor
|
@JochenDeBie I create a PR to revert the portal views changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since many implementations are getting hit by report crashes while OCA/product-attribute#2211 has yet to be merged... 😓
Partially revert a1eea87 for purchase order and quotation report templates. The reverted portions rely on methods
(hide_secondary_uom_column, get_secondary_uom_display_mode) introduced by OCA/product-attribute#2211, which is not yet merged. Without that dependency, the reports would crash when printing.
The secondary quantity column is kept but the conditional visibility and display mode logic are removed until the dependency is available.
@qrtl