[FIX] Control the multi purchase order case in the pending field#3026
Open
Vicent-S73 wants to merge 1 commit intoOCA:17.0from
Open
[FIX] Control the multi purchase order case in the pending field#3026Vicent-S73 wants to merge 1 commit intoOCA:17.0from
Vicent-S73 wants to merge 1 commit intoOCA:17.0from
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
OCA-git-bot
added
series:17.0
mod:purchase_advance_payment
LoisRForgeFlow
suggested changes
Apr 24, 2026
Contributor
LoisRForgeFlow
left a comment
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Can you add a test case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a case of an invoice that group multiple purchase orders, this compute assumes that the 100% of invoice payments are from a single PO, This new loop handles the possibility that lines from different orders may be distinct and not be added together