-
-
Notifications
You must be signed in to change notification settings - Fork 349
[17.0][IMP] base_report_to_printer : add output_tray #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
7c00129 to
283ccc7
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
283ccc7 to
84b8d5f
Compare
eb05b6f to
0d07f92
Compare
- Enables selection of printer output tray
0d07f92 to
682f255
Compare
|
Hello, here is a nice addition ready for review! |
|
@chienandalu @pedrobaeza Maybe you would like to give a review? |
|
These are deep changes that require migration scripts to adapt existing models and fields. |
|
@pedrobaeza Added migration scripts. |
pedrobaeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a code review, it sounds OK
|
Hi @sergio-teruel, Just a friendly ping on this PR when you get a chance. Let me know if you have any questions or need more context! Thanks! |
|
This PR has the |
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@pedrobaeza There is a test failure in module |
|
Well, I can't merge it being red, so I can't go any further. |
d428464 to
89c822a
Compare
|
@pedrobaeza My branch doesn't produce this error. I don't know how to resolve the issue. |
|
It seems to be intermittent. Let's try again: /ocabot merge minor |
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
This pull request refactors the printer tray handling in the
base_report_to_printermodule to support separate input and output trays, improving flexibility.Model and Field Refactoring
printing.traymodel into two distinct models:printing.tray.inputandprinting.tray.output, and updated all related fields inir.actions.report,printing.printer,printing.report.xml.action, andres.usersto use these new models for input and output trays.Printer Synchronization and Options
Security and Access Control
Tests and Backwards Compatibility
Miscellaneous
17.0.1.1.2to reflect these changes.