[18.0][FIX] printing_auto_base: Fix record relation and filtering #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @jbaudoux, |
mmequignon
force-pushed
the
printing_auto_base-fix_filtering
branch
from
78f95cb to
2758341
Compare
simahawk
approved these changes
Oct 28, 2025
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
LG. The build issue seems unrelated.
TDu
approved these changes
Oct 29, 2025
jbaudoux
approved these changes
Oct 29, 2025
Contributor
|
Failing test not related to this PR |
Contributor
|
@mt-software-de Can you review this change as you use this module. Please confirm you're not affected by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying the condition to filter out invalid records, it must be done on the related record defined in
record_change, if any.