[IMP] fastapi: detail to have ValueError exception message

[anikeenko-viktor]

Previously, detail contained only "Internal Server Error" in case of ValueError exception.
Now, it contains an actual exception message

[OCA-git-bot]

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

[lmignon]

IMO we must be very careful about the provided informations in case of error. We are conscious of the fact that no information is returned in the event of an error that is too generic, in order to prevent it from being used in the development of API attack scenarios by hackers. So I'm not in favor of this change, but let's see what others think.

[anikeenko-viktor]

Realised that handling only ValueError is not enough in my case. I think we should have ability to see detailed error info somehow. Probably need to add some kind of DEBUG flag and show detailed error info only if it's provided (in staging, local servers for example)

[lmignon]

Realised that handling only ValueError is not enough in my case. I think we should have ability to see detailed error info somehow. Probably need to add some kind of DEBUG flag and show detailed error info only if it's provided (in staging, local servers for example)

Why not but errors and stacktrace are available into the log file.

[lmignon]

Suggested change

	if os.getenv("FASTAPI_DEBUG") == "1":
	details = repr(exc)
	else:
	details = "Internal Server Error"
	details = "Internal Server Error"
	if config.get_misc("fastapi", "dev_mode"):
	traceback = "".join(traceback.format_exception(*sys.exc_info()))
	details = f"{details}\n{traceback}"

you must also import the right modules...

import sys
import traceback

from odoo.tools.config import config

[anikeenko-viktor]

Thanks for the suggestion. Applied with slight changes.

[lmignon]

The version will be changed at merge time. Can you remove this change plz.

[lmignon]

This config should be added into the documentation in a readme/CONFIGURE.rst (ex https://github.com/OCA/rest-framework/blob/16.0/base_rest/readme/CONFIGURE.rst)

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.