[18.0] [FIX] fastapi: support both starlette < and >= 0.48

[ivantodorovich]

Recent merged changes in a5bae2b changed status.HTTP_422_UNPROCESSABLE_ENTITY to status.HTTP_422_UNPROCESSABLE_CONTENT in order to supress a deprecation warning emitted by the starlette >= 0.48 library.

However, older versions of starlette will simply break with this change.

Module 'starlette.status' has no attribute 'HTTP_422_UNPROCESSABLE_CONTENT'.
Did you mean: 'HTTP_422_UNPROCESSABLE_ENTITY'?

For this reason, we bump the minimum required version of fastapi to 0.120.0, which consumes newer versions of starlette where this is not an issue.

To be compatible with past and future versions, we simply use the integer value 422, aligning also with the updated fastapi documentation:

See:

• ⬆️ Upgrade Starlette supported version range to >=0.40.0,<0.49.0 fastapi/fastapi#14077

[OCA-git-bot]

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

[lmignon]

@ivantodorovich IMO We should revert the change related to status.HTTP_422_UNPROCESSABLE_ENTITY to support the same range of starlette version as in fastapi "starlette>=0.40.0,<0.50.0". The depreciation has been introduced in starlette 0.48....

[ivantodorovich]

Hi @lmignon !

What I don't like about that is that we will hit this issue in the future, at some point. Today it's a deprecation warning, but soon will be an exception.

But I see your point wanting to support older versions, too.. so perhaps we could do the same fastapi did in their project:

• ⬆️ Upgrade Starlette supported version range to >=0.40.0,<0.49.0 fastapi/fastapi#14077

That is, replace the use of these constants with their simple integer value (e.g.: 422).
Or, maybe more elegantly, use the correct one depending on the starlette package version.

I'll update this PR with a new proposal

[ivantodorovich]

@lmignon when you have a moment, please check the new proposal 🙏🏻
Thanks!

[lmignon]

Thank you @ivantodorovich. This fix is pragmatic and solve the issue without introducing additional constrain.

[lmignon]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-572-by-lmignon-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 62b5c7e. Thanks a lot for contributing to OCA. ❤️