[18.0][FIX] sale_exception: Rollback confirmation upon exception #3885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
changed the title
Contributor
Author
|
FTR: this is not new #2667 😭 |
Contributor
|
Hi @grindtildeath Is there any progress on this? Could you check this https://github.com/OCA/sale-workflow/compare/16.0...adhoc-dev:sale-workflow:16.0-h-89839-lav2?expand=1 ? |
Contributor
Author
|
@lef-adhoc Sorry for the lack of answer, I had something in backlog to get back to this issue but did not have much time to work on it before the last few days, thanks to the holiday season. I did work on a POC that would rollback any transaction where an exception rule is detected, but this had to be done in base_exception module: OCA/server-tools#3476 It still needs to be improved and we'll need tests, but AFAICT first results are promising. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.