-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[18.0][MIG] sale_order_product_recommendation_packaging_default: Migration 18.0 #4096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chienandalu
wants to merge
12
commits into
OCA:18.0
Choose a base branch
from
moduon:18.0-mig-sale_order_product_recommendation_packaging_default
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] sale_order_product_recommendation_packaging_default: Migration 18.0 #4096
chienandalu
wants to merge
12
commits into
OCA:18.0
from
moduon:18.0-mig-sale_order_product_recommendation_packaging_default
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/ocabot migration sale_order_product_recommendation_packaging_default |
This module extends the functionality of sale order product recommendations to support gathering and specifying product packaging and to allow you to input that info directly from the recommendations wizard. To know how to use this module, follow the usage instructions of `sale_order_product_recommendation`. If your database uses product packagings, you should be able to see and use 2 new columns in the recommendations wizard: - *Packaging* - *Packaging Qty.* @moduon MT-3489
…oduct without packaging Before this patch, when a product had no packaging, we got an error. @moduon MT-4326
It turns out that, since product packagings can be sorted, and can already be set as `sales=True`, we can safely consider that the 1st packaging with that field on is the default one for sales. We loose the ability to set one product with sales packagings to not have a default one, but we win in the sense that we don't diverge from Odoo CE DB model. That advantage means that the "packaging_default" family of modules are now just a plug-in that will emphasize the usage of packagings in the sale process, but other modules that use the same data model can reason similarly without depending directly on these ones. @moduon MT-4396
…ckaging fields in mobile views In this case, the qty is always visible, to avoid UI jumps if the when the user uses buttons from the numeric step widget, if OCA/web#2691 is included. Also, that module is added to dependencies. @moduon MT-4397 MT-4396
…te packaging Now it includes the default product in the context, so when you use quick creation actions, it will behave as expected. @moduon MT-4472
…date of preexisting lines, and don't fail if there's no packaging permissions @moduon MT-4472
…gating recommendations to sale order
…ate packaging if quantities has not changed
e6d923f to
0d91075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
cc @moduon MT-11826
please check @Shide