[18.0][IMP] sale_order_secondary_unit: show secondary unit prices according to the configuration#4152
Open
AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
Open
[18.0][IMP] sale_order_secondary_unit: show secondary unit prices according to the configuration#4152AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
Conversation
AungKoKoLin1997
force-pushed
the
18.0-imp-sale_secondary_unit
branch
from
5ed0147 to
cdea8c8
Compare
alexey-pelykh
approved these changes
Feb 28, 2026
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Substantial improvement — portal support and the flexible display mode (primary/secondary/both) are well thought out. The get_secondary_uom_display_mode() pattern keeps it extensible. Templates look good.
Code review LGTM.
AungKoKoLin1997
force-pushed
the
18.0-imp-sale_secondary_unit
branch
from
cdea8c8 to
de2066c
Compare
… to the configuration
AungKoKoLin1997
force-pushed
the
18.0-imp-sale_secondary_unit
branch
from
de2066c to
d4c4b87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the sale report and portal to show secondary unit information according to the configuration.
Depends on OCA/product-attribute#2182
@qrtl QT6210