[18.0][IMP] sale_exception: Use hook to popup exception after rollback#4255
Open
grindtildeath wants to merge 8 commits intoOCA:18.0from
Open
[18.0][IMP] sale_exception: Use hook to popup exception after rollback#4255grindtildeath wants to merge 8 commits intoOCA:18.0from
grindtildeath wants to merge 8 commits intoOCA:18.0from
Conversation
grindtildeath
changed the title
2 tasks
With OCA/server-tools#3590 changing the way exceptions are detected, the error raising doesn't allow to call `_popup_exception` as we used to, but we can use the new hook to have the popup displayed smoothly.
…tted Since main transaction is rollbacked in the new version of base_exception we need a dedicated transaction to persist the exceptions on the sale order lines.
grindtildeath
force-pushed
the
18.0-imp-sale_exception_rollback_popup
branch
from
e30bc31 to
0ec20a9
Compare
OCA-git-bot
added
the
mod:sale_exception_product_sale_manufactured_for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With OCA/server-tools#3590 changing the way exceptions are detected, the error raising doesn't allow to call
_popup_exceptionas we used to, but we can use the new hook to have the popup displayed smoothly.Depends on: