[19.0][MIG] sale_product_set: Migration to 19.0 by CRogos · Pull Request #4283 · OCA/sale-workflow

CRogos · 2026-04-16T19:14:27Z

supersede: #3941

rousseldenis · 2026-04-29T07:53:27Z

/ocabot migration sale_product_set

OCA-git-bot · 2026-04-29T07:53:41Z

The migration issue (#3914) has not been updated to reference the current pull request because a previous pull request (#3941) is not closed.
Perhaps you should check that there is no duplicate work.
CC @mmrondon

rousseldenis · 2026-04-29T07:53:59Z

/ocabot migration sale_product_set

rousseldenis

LGTM

rousseldenis · 2026-04-29T07:55:15Z

@BhaveshHeliconia Could you review? Thanks

BhaveshHeliconia

I got an error while testing.

BhaveshHeliconia · 2026-04-29T08:39:08Z

S00026.mp4

* when a set is added to a sales order, it passes the unit of measure of the product to the sales order line. Fixes an incompatibility with module sale_margin.

…#543) * [imp] move SO `add set` button to smartbutton header * [fix] sale_product_set: PEP8

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_product_set/es/

Currently translated at 33.3% (12 of 36 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set/it/

If the user plays too much with sequences on the product set, it's possible to have some negative sequences. But when the set is applied on the SO negative sequences are added to max_sequence. As the sequence is < 0 it adds the product 'in the middle' of the SO instead of let grouped every product's set.

Currently translated at 36.1% (13 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/it/

Currently translated at 58.3% (21 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/sl/

[UPD] Update sale_product_set.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Translated using Weblate (Spanish) Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/ [UPD] README.rst

Translated using Weblate (Italian) Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/ [UPD] Update sale_product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Translated using Weblate (Italian) Currently translated at 100.0% (26 of 26 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/ Translated using Weblate (Spanish) Currently translated at 100.0% (26 of 26 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/

… product_set The reason to move this logic is that there are other modules that extend product_set as for example stock_product_set but at the same time make use of the transient model to define a wizard. For this reason it is better to have the logic available in product_set module and avoid duplicating code or inheriting from sale_product_set and what this implies in their respective dependencies with the only need to extend the transient model. In addition, the transient model is renamed to make it clearer to identify that it is this type of model. TT48100 [UPD] Update sale_product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/de/

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/sv/

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/it/

[MIG] sale_product_set: add migration to 18.0 for syncing product set state

TT54298

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_product_set/tr/

CRogos · 2026-04-29T15:13:22Z

@BhaveshHeliconia could you retest. I think this was related to a 0.0 unit_price.

BhaveshHeliconia

I’ve retested it, but I’m still getting the same error on Runbot.
I also tested it locally, and it works fine there without any error.

MohamedOsman7 · 2026-04-30T12:27:24Z

If i add a set, then change the Quantity of the products, the amount will be set to 0:

CRogos · 2026-04-30T20:40:24Z

@MohamedOsman7 The quantity issue was related to a not correctly set uom_id.
@BhaveshHeliconia could you also retest... for me it is now working on runboat.

OCA-git-bot added series:19.0 mod:sale_product_set Module sale_product_set labels Apr 16, 2026

CRogos force-pushed the copilot/migrate-sale-product-set-18-0-to-19-0 branch 3 times, most recently from f4efb91 to 7802b2c Compare April 17, 2026 11:12

CRogos marked this pull request as ready for review April 17, 2026 11:21

CRogos force-pushed the copilot/migrate-sale-product-set-18-0-to-19-0 branch 3 times, most recently from 72ce950 to ff86f7e Compare April 20, 2026 12:30

BhaveshHeliconia mentioned this pull request Apr 23, 2026

[19.0][MIG] sale_wishlist: Migration to 19.0 #4308

Open

OCA-git-bot added this to the 19.0 milestone Apr 29, 2026

OCA-git-bot mentioned this pull request Apr 29, 2026

Migration to version 19.0 #3914

Open

rousseldenis approved these changes Apr 29, 2026

View reviewed changes

BhaveshHeliconia suggested changes Apr 29, 2026

View reviewed changes

Pierre Verkest and others added 11 commits April 29, 2026 14:37

[add] sale_product_set

b04edb8

[10.0][MIG] sale_product_set

800c5c2

[10.0][FIX][sale_product_set] incompatibility with sale_margin (OCA#519)

6c78276

* when a set is added to a sales order, it passes the unit of measure of the product to the sales order line. Fixes an incompatibility with module sale_margin.

[10.0][IMP] sale_product_set: move add set smart button header (OCA…

96a5ba6

…#543) * [imp] move SO `add set` button to smartbutton header * [fix] sale_product_set: PEP8

[MIG][11.0] sale_product_set

c44e078

remove obsolete .pot files [ci skip]

e79cb3d

[UPD] Update sale_product_set.pot

783a973

Translated using Weblate (Spanish)

e01e319

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_product_set/es/

[MIG] - Migration 12.0 sale_product_set

34ab115

[IMP] - refresh sale_product_set.pot

c1e0fc3

[REM] - Remove version="7.0" reference in xml views

58afb90

francesco-ooops and others added 18 commits April 29, 2026 14:37

Translated using Weblate (Italian)

7960c58

Currently translated at 33.3% (12 of 36 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set/it/

[MIG]sale_product_set: Migration to 15.0

b5c2c89

Translated using Weblate (Italian)

57688ae

Currently translated at 36.1% (13 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/it/

Translated using Weblate (Slovenian)

d25d766

Currently translated at 58.3% (21 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/sl/

[MIG] sale_product_set: Migration to 16.0

5e459f8

[IMP] sale_product_set: pre-commit auto fixes

c914740

[MIG] sale_product_set: Migration to 17.0

7373bd2

Translated using Weblate (German)

7c8861a

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/de/

Translated using Weblate (Swedish)

bab1221

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/sv/

Translated using Weblate (Italian)

9cbec42

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/it/

[IMP] synchronize active state between partner and product set

7bda418

[MIG] sale_product_set: add migration to 18.0 for syncing product set state

[IMP] sale_product_set: pre-commit auto fixes

1b8e12f

[MIG] sale_product_set: Migration to 18.0

3bf728f

TT54298

Translated using Weblate (Turkish)

b45f7b3

Currently translated at 100.0% (25 of 25 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_product_set/tr/

CRogos force-pushed the copilot/migrate-sale-product-set-18-0-to-19-0 branch from ff86f7e to 02f3969 Compare April 29, 2026 14:37

BhaveshHeliconia reviewed Apr 30, 2026

View reviewed changes

RaphaelVicini mentioned this pull request Apr 30, 2026

[19.0][MIG] sale_product_set: Migration to 19.0 #3941

Closed

CRogos force-pushed the copilot/migrate-sale-product-set-18-0-to-19-0 branch from 02f3969 to cfaafe8 Compare April 30, 2026 20:22

CRogos added 2 commits April 30, 2026 20:31

[MIG] sale_product_set: Migration to 19.0

13ca406

[DO NOT MERGE] temporary dependency

cb46f3d

CRogos force-pushed the copilot/migrate-sale-product-set-18-0-to-19-0 branch from cfaafe8 to cb46f3d Compare April 30, 2026 20:31

BhaveshHeliconia approved these changes May 1, 2026

View reviewed changes

OCA-git-bot added the approved label May 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] sale_product_set: Migration to 19.0#4283

[19.0][MIG] sale_product_set: Migration to 19.0#4283
CRogos wants to merge 76 commits intoOCA:19.0from
c4a8-odoo:copilot/migrate-sale-product-set-18-0-to-19-0

CRogos commented Apr 16, 2026

Uh oh!

rousseldenis commented Apr 29, 2026

Uh oh!

OCA-git-bot commented Apr 29, 2026

Uh oh!

rousseldenis commented Apr 29, 2026

Uh oh!

rousseldenis left a comment

Uh oh!

rousseldenis commented Apr 29, 2026

Uh oh!

BhaveshHeliconia left a comment

Uh oh!

BhaveshHeliconia commented Apr 29, 2026

Uh oh!

CRogos commented Apr 29, 2026

Uh oh!

BhaveshHeliconia left a comment

Uh oh!

MohamedOsman7 commented Apr 30, 2026

Uh oh!

CRogos commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

CRogos commented Apr 16, 2026

Uh oh!

rousseldenis commented Apr 29, 2026

Uh oh!

OCA-git-bot commented Apr 29, 2026

Uh oh!

rousseldenis commented Apr 29, 2026

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Apr 29, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Apr 29, 2026

Uh oh!

CRogos commented Apr 29, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

MohamedOsman7 commented Apr 30, 2026

Uh oh!

CRogos commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants