[FIX] auth_admin_passkey : AccessError sending mail #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please change module version number according https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers |
Contributor
Author
|
@pedrobaeza : Thanks for pointing that. Yes I'll do it. Just waiting approvals and see with the state of other current PR that changes version number. (ref : #1228) to avoid useless conflicts. For the time being, what is your point of view about that fix ? kind regards. |
pedrobaeza
approved these changes
Jun 21, 2018
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Sorry, I didn't push on the approval
Fenkiou
approved these changes
Jun 24, 2018
Contributor
Author
|
version bumbed. commits squashed and merged. thanks for your review. |
daramousk
pushed a commit
to daramousk/server-tools
that referenced
this pull request
Jul 16, 2018
* [FIX] AccessError sending mail
remihb
pushed a commit
to osiell/server-tools
that referenced
this pull request
Jan 3, 2019
* [FIX] AccessError sending mail
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (9.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
during the process of sending the email, the admin user is browsed by the current user. This can raise undesired AccessError if the admin user is not accessible by the current user at line 33. (try to access to admin_user.email).
this trivial patch fixes this problem.
Thanks for your review.
regards.
CC : @sebalix, @Fenkiou