8.0 base field validator #246

eLBati · 2015-09-02T13:32:23Z

Following #238

hurrinico · 2015-09-03T07:36:10Z

IMHO 👍

lmignon · 2015-09-03T08:31:47Z

base_field_validator/README.rst

make the title a real title by adding a lot of '===' above the title OCA/maintainer-tools@d51c38f

eLBati · 2015-09-04T16:21:11Z

@lmignon thanks. I have made some changes 😁

moylop260 · 2015-09-04T18:19:12Z

base_field_validator/ir_model_field_regex.py

Can you remove size param?
In v8 size don't is required

eLBati · 2015-09-07T08:29:05Z

@moylop260 thanks, I made the suggested changes

moylop260 · 2015-09-07T13:59:13Z

👍

StefanRijnhart · 2015-10-16T14:05:04Z

base_field_validator/models/ir_model.py

Maybe iterate directly over

self.env['ir.model.validator.line'].search( [('name.model', '=', model_name), ('field_id.name', 'in', vals.keys())])

?

eLBati · 2015-10-19T14:17:00Z

@StefanRijnhart thanks, improved with 50f50c3

eLBati · 2015-12-15T09:33:57Z

Hi @StefanRijnhart can this be merged?

StefanRijnhart · 2015-12-15T09:37:40Z

base_field_validator/models/ir_model.py

This check is now redundant, as we already filter on the field name in the search call.

StefanRijnhart · 2015-12-15T09:38:03Z

Nearly!

eLBati · 2015-12-15T10:13:57Z

@StefanRijnhart thanks, done

StefanRijnhart · 2015-12-15T10:25:55Z

base_field_validator/models/ir_model.py

As @hbrunn mentioned recently in another PR, changing the signature of _register_hook can be dangerous as it is not compatible with other overrides of this method on the same model. https://github.com/OCA/server-tools/pull/300/files#r45976286. BTW @eLBati as the author of the module from that pull request you might want to read up on the general discussion there.

eLBati · 2016-02-05T11:50:52Z

@StefanRijnhart thanks for #340
I committed eLBati@8efad99

yajo · 2016-02-05T12:31:29Z

base_field_validator/models/ir_model.py

+
+class IrModelValidatorLine(models.Model):
+    _name = "ir.model.validator.line"
+    name = fields.Many2one('ir.model', string="Model", required=True)


You should call this field model_id.

Thanks, changed

yajo · 2016-02-05T12:48:34Z

In runbot, after I added the validator to the email field of res.partner, I got this:

Odoo Server Error

Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/http.py", line 537, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/http.py", line 574, in dispatch
    result = self._call_function(**self.params)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/http.py", line 310, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/service/model.py", line 118, in wrapper
    return f(dbname, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/http.py", line 307, in checked_call
    return self.endpoint(*a, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/http.py", line 803, in __call__
    return self.method(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/http.py", line 403, in response_wrap
    response = f(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/addons/web/controllers/main.py", line 944, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/addons/web/controllers/main.py", line 936, in _call_kw
    return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/api.py", line 268, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/addons/base_optional_quick_create/model.py", line 62, in write
    self._register_hook(cr, ids)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3141119-246-8efad9/openerp/api.py", line 268, in wrapper
    return old_api(self, *args, **kwargs)
TypeError: _register_hook() takes exactly 2 arguments (3 given)

eLBati · 2016-02-05T14:48:08Z

@yajo thanks for review.

The error

TypeError: _register_hook() takes exactly 2 arguments (3 given)

is fixed with #352

OCA#340

eLBati · 2016-02-22T16:14:51Z

@yajo as per #352 , I refactored method wrapping using _patch_method (d436897)
Please review.
Thanks

yajo · 2016-02-23T08:20:07Z

base_field_validator/models/ir_model.py

+        return True
+
+
+class IrModel(orm.Model):


You do not need to declare this twice. Old and new api methods can be freely mixed in the same models.Model subclass.

yajo · 2016-02-23T08:33:56Z

Finished code review, cannot test functionally due to lack of runbot. I see that in many PR recently, any clues?

…subclass

eLBati · 2016-02-23T16:21:03Z

Thanks @yajo , I addressed your remarks.

I don't know about runbot, you can try asking in #oca https://botbot.me/freenode/oca/

yajo · 2016-02-24T10:44:20Z

base_field_validator/models/ir_model.py

+    _name = "ir.model.validator.line"
+    _rec_name = 'model_id'
+    model_id = fields.Many2one('ir.model', string="Model", required=True)
+    field_id = fields.Many2one('ir.model.fields', 'Field', required=True)


I still feel these 2 fields are redundant. model_id could be a related field to field_id.model_id.

I can't see how to make the interface work using a related field.
Now runbot should work : https://runbot.odoo-community.org/runbot/build/3142519
Please try it there and tell me how you would change it.
Thanks

I think yout do not need to replace the UI. Just add related='field_id.model_id', store=True to the model_id field. It should keep on working as now, but you would not need to fill that field.

In both cases user does not have to fill model_id field, as it is the inverse m2o of validator_line_ids and is not visible

Yes, I suppose I would have strucutred it a bit differently, but current structure works fine and is not too far away of that, so 👍

yajo · 2016-02-26T09:51:35Z

👍

Syncing from upstream OCA/server-tools (10.0)

eLBati mentioned this pull request Sep 2, 2015

Add module validator v8 #238

Closed

lmignon reviewed Sep 3, 2015
View reviewed changes

moylop260 reviewed Sep 4, 2015
View reviewed changes

base_field_validator/ir_model_field_regex.py Outdated

Copy link

Contributor

moylop260 Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove size param?
In v8 size don't is required

moylop260 mentioned this pull request Sep 4, 2015

[ADD] pylint_oca: Add pylint plugin script to check OCA guidelines OCA/maintainer-quality-tools#234

Merged

eLBati force-pushed the 8.0-base_field_validator branch from 84e0520 to e7df826 Compare September 7, 2015 07:56

StefanRijnhart reviewed Oct 16, 2015
View reviewed changes

StefanRijnhart reviewed Dec 15, 2015
View reviewed changes

eLBati force-pushed the 8.0-base_field_validator branch from 50f50c3 to d196c92 Compare December 15, 2015 10:13

StefanRijnhart reviewed Dec 15, 2015
View reviewed changes

eLBati force-pushed the 8.0-base_field_validator branch from d196c92 to a1e82ca Compare January 26, 2016 11:21

eLBati force-pushed the 8.0-base_field_validator branch from a1e82ca to 37380ba Compare February 5, 2016 11:20

yajo reviewed Feb 5, 2016
View reviewed changes

eLBati added 2 commits February 22, 2016 15:38

[REF] module renamed to base_field_validator

1eaa72a

[ADD] icon

fa16db3

eLBati and others added 5 commits February 22, 2016 15:38

IMP dir struct and copyright

04b524b

[FIX] add if on vals

fe05696

Improve validator_line check

83805f3

[FIX] keep _register_hook's signature and call super

6b61011

OCA#340

rename field model_id

cd60474

eLBati force-pushed the 8.0-base_field_validator branch from a603af8 to cd60474 Compare February 22, 2016 14:38

REF using _patch_method

d436897

yajo reviewed Feb 23, 2016
View reviewed changes

eLBati added 6 commits February 23, 2016 16:48

Old and new api methods can be freely mixed in the same models.Model …

9eb8c03

…subclass

No need for pot files

6ad0509

FIX module version

0a192c6

FIX copyright header

dfd4330

use the same example of demo data for email

91df5ad

moving email regex to module data and adding unique constraint

fccb35c

yajo reviewed Feb 24, 2016
View reviewed changes

gurneyalex merged commit 9245f7c into OCA:8.0 Aug 9, 2016

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#246 from OCA/10.0

8f8bc85

Syncing from upstream OCA/server-tools (10.0)

Uh oh!

8.0 base field validator #246

8.0 base field validator #246

Uh oh!

Conversation

eLBati commented Sep 2, 2015

Uh oh!

hurrinico commented Sep 3, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati commented Sep 4, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati commented Sep 7, 2015

Uh oh!

moylop260 commented Sep 7, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati commented Oct 19, 2015

Uh oh!

eLBati commented Dec 15, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart commented Dec 15, 2015

Uh oh!

eLBati commented Dec 15, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eLBati commented Feb 5, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo commented Feb 5, 2016

Uh oh!

eLBati commented Feb 5, 2016

Uh oh!

eLBati commented Feb 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo commented Feb 23, 2016

Uh oh!

eLBati commented Feb 23, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo commented Feb 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants