[FIX] use a nonserialized cursor for updating user groups #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Serialized=True to avoid serialized?
Member
Author
There was a problem hiding this comment.
@moylop260 thanks so much, I messed up the only thing that was to mess up here...
Member
|
Are you sure you don't need to serialize? How user get correct groups then? |
Member
Author
|
Using a nonserialized cursor doesn't always help, as the ORM also wants to update the user's |
Member
Author
|
@pedrobaeza the worst thing that can happen is to have not all dynamic groups, which will be fixed with the next login |
Contributor
|
Is posible add a test case that reproduce the problem? |
Member
Author
|
difficult, because it's a timing issue with multiple users involved |
Contributor
|
👍 |
1 similar comment
Member
|
👍 |
StefanRijnhart
added a commit
that referenced
this pull request
Oct 30, 2015
…r_serialized [FIX] use a nonserialized cursor for updating user groups
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (11.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this in a serialized transaction can cause deadlocks, and we don't need serialization here