Module base_module_doc_rst migrated from version 6.1

[sysadminmatmoz]

I use it as a tool for the relationship graph mostly, but it could be handy for someone else too.

[sysadminmatmoz]

I cleaned what I could (following travis), for the rest I'll need some help.

[moylop260]

Now you don't need invoke to classes

[pedrobaeza]

Check pylint error:

base_module_doc_rst/wizard/tech_rst_guide.py:55: [W1401(anomalous-backslash-in-string), ] Anomalous backslash in string: '\*'. String constant might be missing an r prefix.

[sysadminmatmoz]

That should do it.

[sysadminmatmoz]

Ok, failed builds are not relative to this commit:
************* Module auth_from_http_remote_user.openerp
auth_from_http_remote_user/openerp.py:21: [W0109(duplicate-key), ] Duplicate key 'license' in dictionary
************* Module disable_openerp_online.openerp
disable_openerp_online/openerp.py:27: [W1401(anomalous-backslash-in-string), ] Anomalous backslash in string: '\P'. String constant might be missing an r prefix.

[pedrobaeza]

You still have an error:

./base_module_doc_rst/base_module_doc_rst.py:85:18: F402 import 'fields' from line 24 shadowed by loop variable

[sysadminmatmoz]

Done. You made me set up flake and pylint on my local machine to find out what was the problem! ... And they say that an old dog can't learn new tricks! 😄

[dhp-denero]

he he he.

Thanks,

Dhaval Patel
Team Lead Engineer
Denero Team.
www.deneroteam.com
Skype : deneroteam
Mobile : +91-9327694716

On Fri, Sep 18, 2015 at 9:10 PM, Matjaz Mozetic notifications@github.com
wrote:

Done. You made me set up flake and pylint on my local machine to find out
what was the problem! ... And they say that an old dog can't learn new
tricks! [image: 😄]

—
Reply to this email directly or view it on GitHub
#253 (comment).

[moylop260]

@sysadminmatmoz
You can use git-hook to automate in local lint checks.

[pedrobaeza]

OK, current errors come from another modules. 👍

[sysadminmatmoz]

So why not correcting the other modules since I'm here. 😄

[pedrobaeza]

Thanks for your efforts! It seems that something strange has come in your work, because there are some commits that are mixed that doesn't belong to your PR.

Trying your PR in runbot, I can't get the relationship graph. Sometimes it doesn't say anything, but no image is presented, and sometimes I get this error:

IOError: [Errno 2] No such file or directory: u'/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3115452-253-45af56/openerp/addons/base_module_doc_rst/module.png'

And the RST generated is in an unreadable format. It's not plain RST?

[sysadminmatmoz]

The image gets presented only for the modules that are really currently installed (not just present as installable) in the same database where you run the creation button. The RST is the sphinx RST (as defined in description) - the output file is a gzip archive containing index.rst, module.rst and relations graph.

What commits not belonging to the PR do you mean? 2 files are just corrections to modules that Travis complained about, 2 are relative to a merge, since the repository was updated since I made the original PR.

Regarding the issue: could it be a rebase problem? It works quite fine on a real instance DB.

and sphinx output after make html:

[pedrobaeza]

Thanks for the explanations. Can you perform then these operations:

• Hide "Relationship Graph" page if module not installed.
• Raise an exception when clicking on "Generate Relationship..." if the module is not installed.

[sysadminmatmoz]

That's one of the reasons I became a member of the community. There are some things I'm good at and some things where I'm not, but I'm sure that someone else in the community is. Professionally I'm a problem solver, I'm good at making things work; but to polish them to the final product I need a specialist, thus someone else 😄 .

I'm sure I'd be able to do what you ask eventually (spending hours of study and experiments as with everything else regarding coding, since it's just a hobby for me and not what I usually really do), but there's sure someone in the community that already knows exactly what to do spending minutes where I would spend hours. So, to make it short: if those operations are a must to get things moving, I'll do it (in a month or so, when I'll have some time to spend on it), but I really hope that someone better than me gets his hands on it way before that. 😄

[pedrobaeza]

Well, I was only suggesting that improvements, but I'm not very interested for now in the module itself, so if you can't work on them, at least annotate them on "Know issues" section, and see if any other can improve them.

[sysadminmatmoz]

Moving the PR in #257 and closing, since I messed up my repo.