[FIX] Existing implementation was broken after API v8 upgrade commit #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gically worked only during user creation for the first time: 5710085 `self` was used instead of `this` on several places. This commit aims to resolve this issue by moving misleading parts out of the get_or_create_user Additionally, logger is loaded during server start.
Member
|
👍 |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
gurneyalex
added a commit
that referenced
this pull request
Nov 27, 2015
[FIX] Existing implementation was broken after API v8 upgrade commit
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Feb 26, 2017
[ADD] web_advancd_search_wildcard
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation was broken after API v8 upgrade commit, it magiically worked only during user creation for the first time:
5710085
selfwas used instead ofthison several places.This commit aims to resolve this issue by moving misleading parts out of the get_or_create_user
Additionally, the logger is now global.