[FIX] Allow to deactivate and restore quick creation without restarting #300
Conversation
base_optional_quick_create/model.py
Outdated
There was a problem hiding this comment.
how about using _patch_method? https://github.com/OCA/OCB/blob/9.0/openerp/models.py#L5268
|
Why don't expand https://github.com/OCA/web/tree/8.0/web_m2x_options? In my opinion, this is more a web client issue than a base/server one. You can take the idea of creating ir.parameter per model like in this module: https://github.com/OCA/social/blame/9.0/mail_restrict_follower_selection/README.rst#L13 |
|
The advantage of this method is that you can set the option per model
instead of per form. It also allows the administrator user to configure
each model, instead of having to add options to all the fields in all
the views (which is how I remember that module works).
|
|
Yeah, I know, but I'm talking about implementing this granularity in that module, and make it at web client level, where it should be (as is this web client who includes the quick create option, not the ORM). Obviously, this requires to be done in JS. |
|
I didn't see that this module already exists, but for me it is a mistake to be implemented this way. |
|
@pedrobaeza maybe you are right but can we keep this module in its current form in the 8.0 branch for the sake of continuity? |
|
OK, but please put a warning about this in the Known issues for the v9 migration. |
|
@StefanRijnhart as #352 is merged, what is the destiny of this? |
[RFR] Don't keep our own check attribute, use the patch mechanism's 'origin' attribute instead [RFR] Only pass models to the patch method that need patching
StefanRijnhart
force-pushed
the
8.0-quick_create_no_restart
branch
from
f1f8b14 to
2c7ca24
Compare
|
@eLBati I have rebased |
|
👍 Can we merge this in 8.0 at least? |
|
👍 thanks |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Syncing from upstream OCA/server-tools (10.0)
6 participants
The implementation marks seen model objects with a special attribute to prevent unnecessary processing. If a model was modified, _register_hook was called but the attribute prevented quick creation to be disabled. Also, re-enabling quick creation at run time was not supported.