[8.0][base_custom_info] New module to have custom information associated to any model

[yajo]

This module does nothing by itself, so don't lose time doing functional reviews. It is the base module that was sent in OCA/product-attribute#120 (comment).

It just adds a base to make other modules able to add a custom attribute list in any model with 2 LOC.

@carlos-incaser @rafaelbn @pedrobaeza.

[pedrobaeza]

This category is not a standard one

[yajo]

All fixed (what needed to be fixed).

[yajo]

Well, now.

[rafaelbn]

Please @sergio-incaser @carlos-incaser @pedrobaeza @antespi could you review? Thanks

[sergio-teruel]

When try enter into a product
Odoo Server Error
Traceback (most recent call last):
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/http.py", line 537, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/http.py", line 574, in dispatch
result = self._call_function(*_self.params)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/http.py", line 310, in _call_function
return checked_call(self.db, *args, *_kwargs)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/service/model.py", line 118, in wrapper
return f(dbname, _args, *_kwargs)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/http.py", line 307, in checked_call
return self.endpoint(_a, *_kw)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/http.py", line 803, in call
return self.method(_args, *_kw)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/http.py", line 403, in response_wrap
response = f(_args, *_kw)
File "/home/sergio/desarrollo/odoo/v80/odoo/addons/web/controllers/main.py", line 944, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/home/sergio/desarrollo/odoo/v80/odoo/addons/web/controllers/main.py", line 936, in _call_kw
return getattr(request.registry.get(model), method)(request.cr, request.uid, _args, *_kwargs)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/api.py", line 256, in wrapper
return old_api(self, _args, *_kwargs)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/models.py", line 3145, in read
result = BaseModel.read(records, fields, load=load)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/api.py", line 254, in wrapper
return new_api(self, _args, *_kwargs)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/models.py", line 3180, in read
self._read_from_database(stored, inherited)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/api.py", line 254, in wrapper
return new_api(self, _args, *_kwargs)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/models.py", line 3367, in _read_from_database
res2 = self._columns[f].get(cr, self._model, ids, f, user, context=context, values=result)
File "/home/sergio/desarrollo/odoo/v80/odoo/openerp/osv/fields.py", line 776, in get
domain = self._domain(obj) if callable(self._domain) else self._domain
File "/home/sergio/desarrollo/odoo/v80/server-tools-yajo/base_custom_info/models/custom_info.py", line 80, in
self.env["ir.model"].search([("model", "=", self._name)]).id)],
AttributeError: 'product.template' object has no attribute 'env'

[yajo]

Could you try now please?

[rafaelbn]

Travis fails

[yajo]

Should be fixed now.

[rafaelbn]

Very nice! Ready!

@carlos-incaser @sergio-incaser @pedrobaeza.

[carlosdauden]

The last two commits are not related witdh this module.
👍

[yajo]

They're there to get Travis 💚

[rafaelbn]

👍 thanks!

[rafaelbn]

Hi, please, this PR is ready to be merged, could any manager take a look? thanks!

[pedrobaeza]

@yajo, you have merged the latest changes from 8.0 branch instead of rebasing. Please remove latest commit, and make a proper rebase, and then I'll merge.

[yajo]

Is there any real difference?

[pedrobaeza]

Yes, see the commits and the diffs. They are reversed

[yajo]

Commits and diffs are OK, I don't know what do you mean...

When you rebase you have to solve conflicts one by one for each problematic commit, and it is a potentially dangerous operation that destroys history. With merge history goes always forward and you only need to solve conflicts once.

That's why I usually prefer merges unless for squashing or something like that: less work, less danger, and at the end you get exactly the same result, so IMHO it's OK as it is 😉

[pedrobaeza]

They are not correct, see https://github.com/Yajo/server-tools/commit/be0981ad0202131ac499c4fa144cfe9b1018010f.

It's not a question of preferences, it's a question of not messing up the commit history.

[yajo]

I'll rebase. ✌️

[yajo]

Rebased

[pedrobaeza]

Thanks.

👍