Skip to content

Conversation

@mikevhe18
Copy link

No description provided.

@oca-clabot
Copy link

Hey @mikevhe18, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • mike (no github login found)

Appreciation of efforts,
OCA CLAbot

@mikevhe18 mikevhe18 closed this Jan 5, 2016
@mikevhe18 mikevhe18 reopened this Jan 5, 2016
@andhit-r
Copy link
Member

andhit-r commented Jan 5, 2016

I think WizardBaseCopyUserAccess should be models.TransientModel, not models.Model

@mikevhe18
Copy link
Author

@andhit-r Yes, you're right. I'd missed it. Thank You

@mikevhe18
Copy link
Author

Dear Community,
Can someone tell me how to pass the coverage/coveralls checks?
I'm a newbie here.
Thank You

@sebalix
Copy link
Contributor

sebalix commented Jan 5, 2016

Hi,

What is the purpose of the module? The description is not very clear to me (I encourage you to follow the CONTRIBUTING guide, and the template module (README.rst, etc).
I read the code, and it seems that the wizard copies the groups of one user on the current user. Excepted the admin user account, no user should be able to do this by default. If a user is able to copy any user rights, this is a security hole. Maybe I do not understand well the purpose of this, that's why I am asking :)

@mikevhe18
Copy link
Author

Hi,

The main purpose of this module is to help out admin to work easier. Sometimes users want to delegate their access right to another user for some reason. Not all user can use this feature , only admin can be.

@sebalix
Copy link
Contributor

sebalix commented Jan 5, 2016

Okay, I was misreading the code (we are using https://github.com/osiell/base_user_role for this kind of use case). Anyway, you should update your module to follow the CONTRIBUTING guidelines (new module in 8.0 should be in written in new API) and add a README.rst file, explaining how to use this module (select users in the list, then launch the action, etc).

@dreispt
Copy link
Member

dreispt commented Sep 16, 2016

Please rebase on latest server-tools 8.0: I can see commits regarding unrelated modules, such as audit_log.

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add self.ensure_one()

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 21, 2021
@github-actions github-actions bot closed this Dec 26, 2021
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review question stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants