-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding Module base_copy_access #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @mikevhe18, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
I think WizardBaseCopyUserAccess should be models.TransientModel, not models.Model |
|
@andhit-r Yes, you're right. I'd missed it. Thank You |
|
Dear Community, |
|
Hi, What is the purpose of the module? The description is not very clear to me (I encourage you to follow the CONTRIBUTING guide, and the template module (README.rst, etc). |
|
Hi, The main purpose of this module is to help out admin to work easier. Sometimes users want to delegate their access right to another user for some reason. Not all user can use this feature , only admin can be. |
|
Okay, I was misreading the code (we are using https://github.com/osiell/base_user_role for this kind of use case). Anyway, you should update your module to follow the CONTRIBUTING guidelines (new module in 8.0 should be in written in new API) and add a README.rst file, explaining how to use this module (select users in the list, then launch the action, etc). |
|
Please rebase on latest server-tools 8.0: I can see commits regarding unrelated modules, such as audit_log. |
…Access(orm.TransientModel)
andhit-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andhit-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use models.TransientModel on https://github.com/OCA/server-tools/pull/323/files#diff-032362b48ae883d61fa810d7f9f83c57R10
andhit-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add self.ensure_one()
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Syncing from upstream OCA/server-tools (9.0)
No description provided.