[FIX] datetime_formatter - Set the correct locale to translate months and days

[sebalix]

This is a common issue with OpenERP/Odoo since a long time: the translation of months and days in non-english dates.
The PR is not a nice fix (a proper fix should be global, and not in this module especially), so it's OK if it is refused.
What do you think?

[hbrunn]

I think your approach is okay. A module that monkey patches this into core would be nicer, but well.

Two questions:

• resetlocale sets the locale to the default locale. Wouldn't it be better to save the current locale and reset that? There might be scenarios where some other code set the locale to whatever else
• I think LC_TIME wins against LC_ALL. Wouldn't it be better to set/reset that?

[sebalix]

@hbrunn yep, LC_TIME is a better option, fixed. Travis error is related to base_external_dbsource.

[hbrunn]

👍 verified pylint errors are unrelated

[hbrunn]

@sebalix please rebase for green builds

[sebalix]

Rebased

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.