[19.0][MIG] base_partition: Migration to 19.0 #3465
+912
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-16.0/server-tools-16.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_partition/es/
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-16.0/server-tools-16.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_partition/it/
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-17.0/server-tools-17.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_partition/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-base_partition Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_partition/
This was referenced Dec 12, 2025
rrebollo
approved these changes
Dec 13, 2025
Contributor
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
Comment on lines
+44
to
+55
| def batch(self, batch_size=None): | ||
| """Yield successive batches of size batch_size, or .""" | ||
| if not (batch_size or "_default_batch_size" in dir(self)): | ||
| raise UserError( | ||
| self.env._( | ||
| "Either set up a '_default_batch_size' on the model" | ||
| " or provide a batch_size parameter." | ||
| ) | ||
| ) | ||
| batch_size = batch_size or self._default_batch_size | ||
| for i in range(0, len(self), batch_size): | ||
| yield self[i : i + batch_size] |
Contributor
There was a problem hiding this comment.
It would be nice include some documentation in addon's description about this method too.
Contributor
There was a problem hiding this comment.
Recently I discovered split_every. Maybe this could be deprecated in favor of the built-in helper.
Comment on lines
+57
to
+63
| def read_per_record(self, fields=None, load="_classic_read"): | ||
| result = {} | ||
| data_list = self.read(fields=fields, load=load) | ||
| for d in data_list: | ||
| key = d.pop("id") | ||
| result[key] = d | ||
| return result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.