[18.0][IMP] spreadsheet_oca: Add Kanban views #84

flotho · 2025-11-21T00:22:26Z

Also add active option

flotho · 2025-11-21T00:24:08Z

ping @DorianMAG @JulienMartinez

legalsylvain · 2025-11-21T09:56:03Z

Hi.

adding active field : ✔️
adding kanban view : ✔️
adding partner / comercial partner field : I dont' see the interest, and I don't see it very clear. Could you elaborate ?
thanks !

flotho · 2025-11-21T10:34:48Z

Hi @legalsylvain
Thanks for the code review

* adding partner / comercial partner field : I dont' see the interest, and I don't see it very clear. Could you elaborate ?
  thanks !

Most of time, we (Mind And Go / Datacup) are using sheets for a specific project, customer etc. We use sheets for computation but also for sharing simple quality process between us. Basically some checklist with colors.
Having a partner on sheets really helps to give context and find easily the document and prevent us to add partner name in the file name.

legalsylvain · 2025-11-21T11:24:49Z

Hi @flotho. Thanks for your reply !

Could we imagine having a M2M fields regarding partners. it could be more generic. (and image can be computed as the image of the first partner).
I see the "commercial" partner quite specific. I mean, for the time being, this field is present only in sale / account module. for all the other modules. (crm / project / etc...) there is a simple partner_id.

@etobella : a point of view here ?

thanks !

etobella · 2025-11-21T11:34:58Z

you are solving the issue by using partner, but wouldn't be cleaner to use res_model and res_id and access/generate them from the thread similar to mgmtsystem.nonconformity?

flotho · 2025-11-21T12:13:32Z

Hum, this leads us to a great path.
we're using commercial partner_id not for commercial purpose but to be able to group by customer company and not by the contact.
I'm totally fan of the M2M field @legalsylvain
@etobella , I'll have a look to your proposal.
Anyway, to ease the merging what could be acceptable in the first step ?
M2m on partner adn without commercial_partner_id ?
Regards

legalsylvain · 2025-11-21T12:52:34Z

Anyway, to ease the merging what could be acceptable in the first step ?

I let @etobella and other main developpers answer on that topic. I didn't contributed on that great repo, and so don't have a clear PoV.

chrisandrewmann · 2025-11-21T13:00:50Z

Thanks @flotho it's great to see and i'm 100% behind a kanban view.
My thoughts below, see the attached mockup image:

I think the icon should be static and possibly changeable - linked to an image field on the spreadsheet.
Alternatively, a mechanism to generate a thumbnail preview could be used similar to Enterprise?
Cursor change and clickable image on left
Menu with 3 options (Open, Settings, Delete)
I'd support having the ability to set a partner_id, but not the commercial partner as I think that's possibly confusing
Instead of defaulting to commercial partner for grouping i'd suggest adding M2M tags, which could be displayed on the kanban card and also easily searchable / groupable

flotho · 2025-11-21T15:24:31Z

Thanks,
Here is my new proposal :

legalsylvain · 2025-11-21T16:02:07Z

Hi @flotho. I put the PR in draft state, as it looks WIP, with red CI. Feel free to mark it as "Ready for review", once all is green and commit have been refactored.
thanks for this improvement !

chrisandrewmann · 2025-11-21T16:18:51Z

@flotho looks really good, I like the new proposal.

Couple of things:

Should add a Configuration > Tags menu to manage the tags
If the image is missing, there should be a default placeholder (suggested the font-awesome icon of a spreadsheet in my example) - Otherwise it's empty whitespace

flotho · 2025-11-21T16:19:39Z

@flotho looks really good, I like the new proposal.

Couple of things:

* Should add a Configuration > Tags menu to manage the tags

* If the image is missing, there should be a default placeholder (suggested the font-awesome icon of a spreadsheet in my example)

you're right.
Yet I won't do it no.
Is it blocking for merging ?

chrisandrewmann · 2025-11-21T16:46:36Z

@flotho looks really good, I like the new proposal.
Couple of things:
* Should add a Configuration > Tags menu to manage the tags

* If the image is missing, there should be a default placeholder (suggested the font-awesome icon of a spreadsheet in my example)
you're right. Yet I won't do it no. Is it blocking for merging ?

I'll wait for other comments @legalsylvain @etobella ?
Personally I think we should fix these 2 points for usability.

flotho · 2025-11-22T10:28:13Z

ping @legalsylvain @etobella @chrisandrewmann , ready for review

chrisandrewmann · 2025-11-22T14:00:48Z

@flotho thanks, changes look good to me.
Quickly tested on runbot.
However CI tests failed due to missing alt tag on img. Should be simple fix, then we can review

flotho · 2025-11-22T14:25:46Z

@flotho thanks, changes look good to me. Quickly tested on runbot. However CI tests failed due to missing alt tag on img. Should be simple fix, then we can review

done !

chrisandrewmann

Looks good to me, approved. Will wait for others

flotho · 2025-11-29T22:45:24Z

Hi @etobella @CarlosRoca13 @chrisandrewmann
Any chance to have a review on this small addition ?
Regards

etobella

I am in favor of the concept of kanban and tags, but I think it will be better to make the res_model, res_id strategy.

flotho · 2025-12-01T08:50:57Z

I am in favor of the concept of kanban and tags, but I think it will be better to make the res_model, res_id strategy.

Noted, thanks for the feedback

pedrobaeza · 2025-12-01T08:53:22Z

@flotho if you remove the partner_id part of this PR, this can be merged, and you can put that part in a extension on your side, or propose the generic way. You can also use a reference field.

flotho · 2025-12-10T14:55:48Z

Thanks @pedrobaeza , it's done ,
ping @etobella your review is welcomed

pedrobaeza

Please reduce commits into 2 (tags and kanban)

spreadsheet_oca/models/__init__.py

pedrobaeza · 2025-12-10T15:14:10Z

spreadsheet_oca/security/ir.model.access.csv

 spreadsheet_oca.access_spreadsheet_spreadsheet_import,access_spreadsheet_spreadsheet_import,spreadsheet_oca.model_spreadsheet_spreadsheet_import,base.group_user,1,1,1,1
 access_spreadsheet_import_mode,access_spreadsheet_oca_revision,model_spreadsheet_spreadsheet_import_mode,base.group_user,1,0,0,0
 access_spreadsheet_select_row_number,access_spreadsheet_select_row_number,model_spreadsheet_select_row_number,base.group_user,1,1,1,1
+access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,group_user,1,1,1,1


Only spreadsheet managers should change tags I think.

That's a matter of taste, IMO.

./src/OCA/manufacture/mrp_bom_tag/security/ir.model.access.csv:access_mrp_bom_tag_manager,Bill Of Material Tag Manager,model_mrp_bom_tag,mrp.group_mrp_user,1,1,1,1 ./src/OCA/server-auth/vault/security/ir.model.access.csv:access_vault_tag,access_vault_tag,model_vault_tag,base.group_user,1,1,1,1 ./src/odoo/addons/website_forum/security/ir.model.access.csv:access_forum_tag_user,forum.tag.user,model_forum_tag,base.group_user,1,1,1,1 ./src/odoo/addons/repair/security/ir.model.access.csv:access_repair_tag_user,Repair Tags user,model_repair_tags,stock.group_stock_user,1,1,1,1

etc.

The examples you are putting, except the first one, it's because there's no manager role. Usually, all the "master data" are only accessible by managers of the area.

The examples you are putting, except the first one, it's because there's no manager role.

I don't get it.
Regarding model_repair_tags for exemple. It is possible to manage tag with stock.group_stock_user group, not only stock.group_stock_manager. (group_stock_manager implies group_stock_user)
Or did I missed something ?

Please don't go off-topic. The topic here is that it's legit to not allow to modify tags to "simple" spreadsheet users, just the managers. That's it.

Is it possible for you to speak correctly and on valid points?
That's not the first time, you're acting like an authoritarian leader. It's annoying to talk with you.
Thank you for questionning yourself on this point.

It's you the one going to off-topics, as I'm talking about spreadsheet tags, not repair tags. And I'm being totally correct. Please tell me in which moment I have not been correct. It's also annoying to talk to you, deviating conversations that are not targeted to you, but to @flotho, who is the author of the PR.

pedrobaeza · 2025-12-11T09:08:05Z

Thanks for the renaming, @flotho

Can you please squash commits as suggested, and what do you think about the tag permissions?

* Add Kanban views * Also add active option [IMP] spreadsheet_oca: * Simplify partner usage * Add tags * Improve kanban view [IMP] spreadsheet_oca: Improve form view [IMP] spreadhseet_oca: add tag menu [IMP] spreadhseet_oca: add default image IMP: Add tag on view [REF] spreadsheet_oca: no more partner [REF] spreadsheet_oca: no more partner [REF] spreadsheet_oca: no more partner [REF]rename file [ACL]Ad specific rule for manager

flotho · 2025-12-11T09:14:21Z

done @pedrobaeza

pedrobaeza · 2025-12-11T09:16:19Z

@flotho I was talking about 2 commits, as you are doing here 2 things: tags and kanban view. The commit message also lacks the first line explanations. And the tag question is still open.

flotho · 2025-12-11T09:19:25Z

oh damned I squashed too much ;-)
Do I need to undo ?
regarding ACL I've already changed the rules to have 2 one for basic user and another for manager

pedrobaeza · 2025-12-11T09:35:46Z

Thank you for the change in the tags. About the commits, if it's not very difficult to you, it would be great to have both features split, but I don't want to press more. Just tell me and let's finish this.

chrisandrewmann · 2025-12-11T09:44:37Z

spreadsheet_oca/views/spreadsheet_spreadsheet.xml

-                    <h1>
-                        <field name="name" placeholder="Name" />
-                    </h1>
+                    <field name="badge_image" widget="image" class="oe_avatar" />


To enable "Archived" ribbon and ability to archive from form, add above:

<field name="active" invisible="1"/> <widget name="web_ribbon" title="Archived" bg_color="text-bg-danger" invisible="active"/>

chrisandrewmann · 2025-12-11T09:47:43Z

spreadsheet_oca/views/spreadsheet_spreadsheet.xml

                    </group>
                </sheet>
            </form>
        </field>


Noticed you added inherited "mail.thread", "mail.activity.mixin" to spreadsheet_spreadsheet.py but didn't enable chatter in the view. Think this would be a welcome simple change. Just add this line after the ending sheet tag:

<chatter/>

legalsylvain

A minor remark. Otherwise, LGTM.

Thanks for this improvment.

legalsylvain · 2025-12-11T10:05:24Z

spreadsheet_oca/security/ir.model.access.csv

 spreadsheet_oca.access_spreadsheet_spreadsheet_import,access_spreadsheet_spreadsheet_import,spreadsheet_oca.model_spreadsheet_spreadsheet_import,base.group_user,1,1,1,1
 access_spreadsheet_import_mode,access_spreadsheet_oca_revision,model_spreadsheet_spreadsheet_import_mode,base.group_user,1,0,0,0
 access_spreadsheet_select_row_number,access_spreadsheet_select_row_number,model_spreadsheet_select_row_number,base.group_user,1,1,1,1
+access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,spreadsheet_oca.group_user,1,0,1,0


Suggested change

access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,spreadsheet_oca.group_user,1,0,1,0

access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,spreadsheet_oca.group_user,1,1,1,0

At least. Otherwise, if a user create a tag, ans if he made a mistake in the name, he can not change it.

Well, I still think that users should only use them (read them), not to modify them. If they are going to be able to create them, but not to remove them, that's worst.

What is your opinion here @flotho, and what do you need ?

Thanks for sharing your PoV.
I'm personally used to install the module that prevent creation on the fly for a user because in the end it produce inconsistent data. Typically the use case @legalsylvain described : if a user create with a bad name
That's why I'm in favor of @pedrobaeza to prevent user to modify the tag. Keeping data consistent should be the responsibility of managers.

¿Then should it be this?:

Suggested change

access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,spreadsheet_oca.group_user,1,0,1,0

access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,spreadsheet_oca.group_user,1,0,0,0

chrisandrewmann

Amazing, thanks for that. Looks good.

OCA-git-bot · 2025-12-12T09:32:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza

Let's merge this although there's an extra commit for the last change.

/ocabot merge minor

OCA-git-bot · 2025-12-16T15:53:16Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-84-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot · 2025-12-16T15:57:39Z

Congratulations, your PR was merged at 308acc8. Thanks a lot for contributing to OCA. ❤️

legalsylvain marked this pull request as draft November 21, 2025 16:00

flotho force-pushed the IMP-spreadsheet_oca branch from 52c210d to 831214d Compare November 21, 2025 16:17

flotho marked this pull request as ready for review November 21, 2025 16:19

chrisandrewmann approved these changes Nov 22, 2025

View reviewed changes

etobella reviewed Nov 30, 2025

View reviewed changes

pedrobaeza added this to the 18.0 milestone Dec 1, 2025

flotho force-pushed the IMP-spreadsheet_oca branch from 50294c8 to 2013125 Compare December 9, 2025 22:36

flotho requested review from chrisandrewmann and etobella December 10, 2025 15:03

pedrobaeza changed the title ~~[IMP] spreadsheet_oca: Add Kanban views~~ [18.0][IMP] spreadsheet_oca: Add Kanban views Dec 10, 2025

pedrobaeza reviewed Dec 10, 2025

View reviewed changes

flotho requested review from legalsylvain and pedrobaeza December 11, 2025 09:06

flotho force-pushed the IMP-spreadsheet_oca branch from 89102ae to c7ea389 Compare December 11, 2025 09:13

chrisandrewmann reviewed Dec 11, 2025

View reviewed changes

legalsylvain reviewed Dec 11, 2025

View reviewed changes

[IMP]Active ribbon and chatter on view

139d165

chrisandrewmann approved these changes Dec 12, 2025

View reviewed changes

chrisandrewmann approved these changes Dec 12, 2025 •

edited

Loading

View reviewed changes

etobella approved these changes Dec 12, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Dec 12, 2025

[IMP]ACL: make tag readonly for basic users

b1fa3b7

pedrobaeza approved these changes Dec 16, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 16, 2025

OCA-git-bot merged commit fe3f4b5 into OCA:18.0 Dec 16, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 16, 2025

	access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,spreadsheet_oca.group_user,1,0,1,0
	access_spreadsheet_spreadsheet_tag,access_spreadsheet_spreadsheet_tag,model_spreadsheet_spreadsheet_tag,spreadsheet_oca.group_user,1,1,1,0

Uh oh!

[18.0][IMP] spreadsheet_oca: Add Kanban views #84

[18.0][IMP] spreadsheet_oca: Add Kanban views #84

Uh oh!

Conversation

flotho commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flotho commented Nov 21, 2025

Uh oh!

legalsylvain commented Nov 21, 2025

Uh oh!

flotho commented Nov 21, 2025

Uh oh!

legalsylvain commented Nov 21, 2025

Uh oh!

etobella commented Nov 21, 2025

Uh oh!

flotho commented Nov 21, 2025

Uh oh!

legalsylvain commented Nov 21, 2025

Uh oh!

chrisandrewmann commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flotho commented Nov 21, 2025

Uh oh!

legalsylvain commented Nov 21, 2025

Uh oh!

chrisandrewmann commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flotho commented Nov 21, 2025

Uh oh!

chrisandrewmann commented Nov 21, 2025

Uh oh!

flotho commented Nov 22, 2025

Uh oh!

chrisandrewmann commented Nov 22, 2025

Uh oh!

flotho commented Nov 22, 2025

Uh oh!

chrisandrewmann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flotho commented Nov 29, 2025

Uh oh!

etobella left a comment

Choose a reason for hiding this comment

Uh oh!

flotho commented Dec 1, 2025

Uh oh!

pedrobaeza commented Dec 1, 2025

Uh oh!

flotho commented Dec 10, 2025

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

legalsylvain Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Dec 11, 2025

Uh oh!

flotho commented Dec 11, 2025

flotho commented Nov 21, 2025 •

edited

Loading

chrisandrewmann commented Nov 21, 2025 •

edited

Loading

chrisandrewmann commented Nov 21, 2025 •

edited

Loading

chrisandrewmann left a comment •

edited

Loading

legalsylvain Dec 10, 2025 •

edited

Loading

pedrobaeza Dec 11, 2025 •

edited

Loading