-
-
Notifications
You must be signed in to change notification settings - Fork 272
[IMP] stock_average_daily_sale: change order of columns in the report #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0
Are you sure you want to change the base?
Conversation
5b86aea to
5223d6a
Compare
ivantodorovich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
This PR has the |
jbaudoux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't make the metrics hidden by default as it's all the purpose this report.
I think this change is more based on a customer preference.
|
I integrated the idea in the last version d5add51 |
5223d6a to
f962e71
Compare
Yes, I agree. I made the metrics fields visible by default here. |
|
@jbaudoux have your concerns been addressed now? |
angelmoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
Hello @jbaudoux can you take a look again and (hopefully) approve? |
After using the module for some time, we find the column order not most readable/logical. Here you can find a suggested order.
I added also a possibility to hide/show most of the columns.