Skip to content

Conversation

@twalter-c2c
Copy link

@twalter-c2c twalter-c2c commented Mar 18, 2025

After using the module for some time, we find the column order not most readable/logical. Here you can find a suggested order.

I added also a possibility to hide/show most of the columns.

@twalter-c2c twalter-c2c marked this pull request as ready for review March 19, 2025 09:56
@twalter-c2c twalter-c2c force-pushed the 14.0-change-columns-order branch from 5b86aea to 5223d6a Compare March 24, 2025 13:29
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't make the metrics hidden by default as it's all the purpose this report.
I think this change is more based on a customer preference.

@jbaudoux
Copy link
Contributor

jbaudoux commented Apr 7, 2025

I integrated the idea in the last version d5add51

@twalter-c2c twalter-c2c force-pushed the 14.0-change-columns-order branch from 5223d6a to f962e71 Compare April 8, 2025 11:22
@twalter-c2c
Copy link
Author

I wouldn't make the metrics hidden by default as it's all the purpose this report. I think this change is more based on a customer preference.

Yes, I agree. I made the metrics fields visible by default here.

@twalter-c2c
Copy link
Author

@jbaudoux have your concerns been addressed now?

Copy link
Member

@angelmoya angelmoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 12, 2025
@twalter-c2c
Copy link
Author

Hello @jbaudoux can you take a look again and (hopefully) approve?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants