[17.0][IMP] stock_quant_history #415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @petrus-v, |
StephaneMangin
force-pushed
the
17.0_IMP_stock_quant_history_add_picking_lock_contraint
branch
5 times, most recently
from
c23f748 to
aee4b61
Compare
StephaneMangin
force-pushed
the
17.0_IMP_stock_quant_history_add_picking_lock_contraint
branch
from
aee4b61 to
47e9bd8
Compare
StephaneMangin
force-pushed
the
17.0_IMP_stock_quant_history_add_picking_lock_contraint
branch
12 times, most recently
from
9d99d62 to
f8197bf
Compare
…hile an history snapshot is generated
StephaneMangin
force-pushed
the
17.0_IMP_stock_quant_history_add_picking_lock_contraint
branch
from
f8197bf to
4207b65
Compare
alexandregaldeano
approved these changes
Jun 3, 2025
| :return: stock.quant.history recordset""" | ||
| self.ensure_one() | ||
| history_model = self.env["stock.quant.history"] | ||
| if self.state == "done" and self.date_done: |
There was a problem hiding this comment.
nitpick: invert if + early return?
| :return: True if the picking can be unlocked | ||
| :raises ValidationError: if not allowed to unlock""" | ||
| self.ensure_one() | ||
| if self.is_locked: |
There was a problem hiding this comment.
nitpick: invert if + early return?
| self.ensure_one() | ||
| if self.is_locked: | ||
| history_lines = self.get_stock_quant_history() | ||
| if history_lines.exists(): |
There was a problem hiding this comment.
nitpick: invert if + early return?
petrus-v
approved these changes
Jun 4, 2025
bosd
approved these changes
Aug 13, 2025
Contributor
|
@rousseldenis Can you please merge? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a constraint on locked picking while an history snapshot is generated.
Included a light refactoring of tests suites.
Propagated from 14.0 PR