[FIX] webservice: WARNING message in logs #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @etobella, |
StephaneMangin
approved these changes
Sep 9, 2024
SilvioC2C
force-pushed
the
16.0-oauth2_fix_warning
branch
from
c747e9f to
6dabd31
Compare
Contributor
Author
|
@simahawk another review, please? 😄 |
Contributor
|
@SilvioC2C pls squash |
The use of a compute method on ``oauth2_flow`` when this field is touched by the server environment mixin causes it to be defined twice as computed, with differents settings, and this ultimately causes a warning message in the logs: ``` WARNING odoo odoo.modules.registry: webservice.backend: inconsistent 'compute_sudo' for computed fields: protocol, url, auth_type, username, password, api_key, api_key_header, oauth2_flow, oauth2_clientid, oauth2_client_secret, oauth2_token_url, oauth2_authorization_url, oauth2_audience, oauth2_scope, content_type ``` We fix this by overriding method ``compute_server_env()``
SilvioC2C
force-pushed
the
16.0-oauth2_fix_warning
branch
from
6dabd31 to
44f41c0
Compare
Contributor
Author
|
@simahawk can we merge this? |
Contributor
|
This PR has the |
gurneyalex
approved these changes
Sep 16, 2024
Member
|
/ocabot merge minor |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 1dd2c7f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of a compute method on
oauth2_flowwhen this field is touched by the server environment mixin causes it to be defined twice as computed, with differents settings, and this ultimately causes a warning message in the logs:We fix this by overriding method
compute_server_env()Supersedes #47