Skip to content

[IMP] shopfloor: Allow to use picking type destination #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rousseldenis wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[IMP] shopfloor: Allow to use picking type destination #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions shopfloor/services/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def is_src_location_valid(self, location):
"""
return location.is_sublocation_of(self.picking_types.default_location_src_id)

def is_dest_location_valid(self, moves, location):
def is_dest_location_valid(self, moves, location, pick_type=False):
"""Check the destination location is valid for given moves.

We ensure the destination is either valid regarding the picking
Expand All @@ -143,9 +143,17 @@ def is_dest_location_valid(self, moves, location):
condition and not anymore this one that has a destination to an
intermediate location)
"""
return location.is_sublocation_of(
moves.picking_id.location_dest_id, func=all
) or location.is_sublocation_of(moves.location_dest_id, func=all)
return (
location.is_sublocation_of(moves.picking_id.location_dest_id, func=all)
or location.is_sublocation_of(moves.location_dest_id, func=all)
or (
location.is_sublocation_of(
moves.picking_type_id.default_location_dest_id, func=all
)
if pick_type
else False
)
)

def is_dest_location_to_confirm(self, location_dest_id, location):
"""Check the destination location requires confirmation
Expand Down