Skip to content

[16.0][FW] stock_dynamic_routing: multiple ports from 14.0 #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sebalix wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][FW] stock_dynamic_routing: multiple ports from 14.0 #809

sebalix wants to merge 2 commits into from

Conversation

@sebalix
Copy link

@sebalix sebalix commented Jan 5, 2024 •
edited
Loading

Port of the following PRs from 14.0 to 16.0:

@sebalix
Copy link
Author

sebalix commented Jan 5, 2024

@jbaudoux An idea why tests in stock_storage_type could fail with these ports?

@jbaudoux
Copy link
Contributor

jbaudoux commented Jan 5, 2024

@jbaudoux An idea why tests in stock_storage_type could fail with these ports?

Try to repush ?

@sebalix sebalix force-pushed the oca-port-from-14.0-to-16.0-pr-722-805 branch from 6be053e to 8ac4961 Compare January 25, 2024 12:20
@sebalix sebalix force-pushed the oca-port-from-14.0-to-16.0-pr-722-805 branch from 8ac4961 to 9f3b4f9 Compare February 28, 2024 13:56
@github-actions
Copy link

github-actions bot commented Jun 30, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 30, 2024
@github-actions github-actions bot closed this Aug 4, 2024
@jbaudoux
Copy link
Contributor

jbaudoux commented Aug 5, 2024

@sebalix Is this still valid ?

@jbaudoux jbaudoux reopened this Aug 5, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@sebalix sebalix force-pushed the oca-port-from-14.0-to-16.0-pr-722-805 branch from 9f3b4f9 to 06b8048 Compare August 28, 2024 15:31
@sebalix
Copy link
Author

sebalix commented Aug 29, 2024

@jbaudoux probably, as these changes exist on 14.0. Now I can't tell you why tests are failing 🤔

@sebalix sebalix force-pushed the oca-port-from-14.0-to-16.0-pr-722-805 branch 2 times, most recently from ad191fa to bbefeed Compare September 2, 2024 12:17
@sebalix
Copy link
Author

sebalix commented Sep 2, 2024

@jbaudoux

I removed these patches from this PR and kept only a unit tested added by #722

@sebalix sebalix marked this pull request as ready for review September 6, 2024 09:26
@jbaudoux jbaudoux self-requested a review October 7, 2024 14:02
@sebalix sebalix added this to the 16.0 milestone Jan 10, 2025
@sebalix sebalix added the port Port or Backport of fixes/features label Jan 10, 2025
@github-actions
Copy link

github-actions bot commented May 11, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 11, 2025
@github-actions github-actions bot closed this Jun 15, 2025
@jbaudoux jbaudoux mentioned this pull request Jun 16, 2025
Merged
@sebalix sebalix reopened this Jul 3, 2025
@sebalix sebalix force-pushed the oca-port-from-14.0-to-16.0-pr-722-805 branch from bbefeed to ae1944b Compare July 3, 2025 09:16
@jbaudoux @sebalix
stock_dynamic_routing: add test
3bbbac9 
Add test for the rerouting of waiting moves in a pull flow
@sebalix sebalix force-pushed the oca-port-from-14.0-to-16.0-pr-722-805 branch from bb7c09b to 726e75b Compare July 3, 2025 11:00
@sebalix
[FIX] stock_dynamic_routing: routing moves has to be MTO
b346a4e 
This is causing trouble by merging back moves in the
`stock_available_to_promise_release_dynamic_routing` glue module which
were split on purpose by the dynamic routing rules.
@sebalix sebalix force-pushed the oca-port-from-14.0-to-16.0-pr-722-805 branch from 726e75b to b346a4e Compare July 3, 2025 11:15
@sebalix sebalix removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaudoux jbaudoux Awaiting requested review from jbaudoux

1 more reviewer

@gbrito gbrito gbrito approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs review port Port or Backport of fixes/features

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sebalix @jbaudoux @gbrito