[IMP] shopfloor: Improve message for location content transfer items #925
Conversation
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
I'm not in favor of this change. The source location is marked as empty when you pick from there. If you partially process a quantity, you will still have to process the remaining quantity to the asked location. If you want to cancel remaining quantity and put back at source, there should be an explicit action with the right steps (and checks)
What is your use case where source location is empty??? |
Someone takes from over-stock location N1 and starts unloading to stock location S2. Someone else moves from input location I3 to the empty N1. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@jbaudoux This change has nothing to do with the flow itself. It adds the source location in the message. Nothing more. |
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
I see the location source is displayed when last content is processed in location_content_transfer_complete
So it makes sense to display it here also :)
But can you do better than Content line ?
| "message_type": "success", | ||
| "body": _("Content transfer to {} completed").format(location_dest.name), | ||
| "body": _( | ||
| "Content line transferred from %(location_name)s to %(location_dest_name)s", |
There was a problem hiding this comment.
What about
| "Content line transferred from %(location_name)s to %(location_dest_name)s", | |
| "Transferred from %(location_name)s to %(location_dest_name)s", |
or
| "Content line transferred from %(location_name)s to %(location_dest_name)s", | |
| "Product %(product_name) transferred from %(location_name)s to %(location_dest_name)s", |
and
| "Content line transferred from %(location_name)s to %(location_dest_name)s", | |
| "Package %(package_name) transferred from %(location_name)s to %(location_dest_name)s", |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Merging this as very old. Improvement later. /ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-925-by-rousseldenis-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
In case of content transfer line by line, user wants to be recalled which origin location he comes from if he wants to transfer partially and put the remaining products back to source (e.g.: no more space on destination location)
rousseldenis
force-pushed
the
16.0-imp-shopfloor-location-content-message-dro
branch
from
3ec1027 to
9bfbe4b
Compare
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 60f4b5a. Thanks a lot for contributing to OCA. ❤️ |
4 participants
In case of content transfer line by line, user wants to be recalled which origin location he comes from if he wants to transfer partially and put the remaining products back to source (e.g.: no more space on destination location)
@phschmidt @jbaudoux @sbejaoui @lmignon
An easy one 😅