fix: prevent nil pointer panic when mission init fails#72
Merged
Conversation
When :INIT: fails (e.g., args passed as 'any' instead of array), no mission is started but subsequent commands like :SAVE:MISSION: still execute. EndMission() and GetExportMetadata() would then dereference the nil b.mission pointer, causing a panic. Add nil checks to return proper errors/empty values instead of crashing.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EndMission()to return error instead of panic when no mission was startedGetExportMetadata()to return empty metadata instead of panicProblem
When
:INIT:fails (e.g., Arma addon passesanyinstead of an array), no mission is started. However, subsequent commands like:SAVE:MISSION:still execute. WhenEndMission()orGetExportMetadata()tried to accessb.missionfields, it caused a nil pointer dereference panic:Test plan
TestEndMissionWithoutStartMission- verifies error returned instead of panicTestGetExportMetadataWithoutStartMission- verifies empty metadata returned instead of panic