Conversation
- Add Position2D and Polyline types to core model - Add Polyline field to Marker structs (core and GORM) - Implement ParsePolyline function in geo package - Update LogMarkerCreate handler to detect and parse polylines - Update export to output coordinate array for polylines - Add conversion from geom.LineString to core.Polyline Polyline markers are now recorded and exported in the format expected by the OCAP2 web UI: [[x1,y1],[x2,y2],...] Fixes issue where user-drawn lines were silently dropped because the handler expected a single [x,y,z] coordinate but received an array of points.
The frontend expects positions in frame-based format: [[frameNum, pos, direction, alpha], ...] For POLYLINE markers, pos should contain the coordinate array: [[frameNum, [[x1,y1], [x2,y2], ...], direction, alpha]] Previously we were outputting raw coordinates without the frame wrapper, which caused the frontend to misinterpret the data.
Merging this branch changes the coverage (3 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[x,y,z]coordinate but received an array of points[[x1,y1],[x2,y2],...]Changes
Position2DandPolylinetypes to core modelPolylinefield to Marker structs (core and GORM)ParsePolyline()function in geo packageLogMarkerCreatehandler to detect POLYLINE shape and parse coordinate arraygeom.LineStringtocore.PolylineTest plan
ParsePolyline()(valid input, edge cases, error handling)