test: add test coverage for marker side value mapping#74
Merged
Conversation
Add TestMarkerSideValues to verify sideToIndex correctly maps side strings (from "str side" SQF command) to numeric indices. Also improve sideToIndex comment to document expected input format and handling of non-combat sides (EMPTY, LOGIC, UNKNOWN).
fank
force-pushed
the
fix/marker-side-resistance-alias
branch
from
0a12847 to
c048990
Compare
fank
changed the title
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestMarkerSideValuestest to verifysideToIndexcorrectly maps side strings to numeric indicessideToIndexcomment to document expected input format from SQF (str sidereturns EAST, WEST, GUER, CIV, EMPTY, LOGIC, UNKNOWN)Test plan
go test ./internal/storage/memory/... -run Sidepasses