Merged
Conversation
Move the export types and builder logic into a dedicated v1 package to prepare for creating a v2 export format. Changes: - Create internal/storage/memory/export/v1/ package - Move Export, Time, Entity types to v1/types.go - Move Build() function and helpers to v1/builder.go - Simplify export.go to use v1 package for building exports - Add BuildExport() public method for thread-safe access - Update tests to use v1.Export type
Add tests covering all functions in the v1 package: - boolToInt: true/false conversion - sideToIndex: all side string mappings (EAST, WEST, GUER, CIV, etc.) - parseMarkerSize: valid/invalid JSON parsing - Build: comprehensive coverage including: - Empty missions - Mission metadata - Time states - Soldiers with states and fired events - Soldiers in vehicles - Vehicles with crew (valid/empty/invalid JSON) - Dead vehicles - General events with JSON message parsing - Hit events (soldier and vehicle IDs) - Kill events (soldier and vehicle IDs) - Markers (regular and polyline shapes) - Color handling (hex prefix stripping) - Sparse entity array indexing - EndFrame calculation from multiple sources Coverage: 100%
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1package atinternal/storage/memory/export/v1/Changes
v1/types.gowithExport,Time,Entitytypesv1/builder.gowithBuild()function and helper utilities (parseMarkerSize,sideToIndex,boolToInt)export.goto use v1 package for building exportsBuildExport()public method on Backend for thread-safe accessv1.ExporttypeNew Structure
Test plan