fix: normalize filename handling with migration script#120
Merged
Conversation
Previously, uploaded files like `foo.json.gz` would only have `.gz` stripped, resulting in filenames like `foo.json` stored in the database and conversion output directories named `foo.json/`. Now both extensions are stripped consistently: - Database stores base name without extensions (e.g., `foo`) - Files on disk use explicit `.json.gz` extension - Conversion output directories use clean base name (e.g., `foo/`) This change requires migration for existing deployments.
Migrates existing deployments from old naming convention to new: - DB: strips .json suffix from filenames - Filesystem: renames output directories (foo.json/ -> foo/)
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.jsonand.gzextensionsMigration
Run
scripts/migrate-filenames.shafter upgrading: