Skip to content

fix: download button not working in streaming mode #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fank merged 1 commit into from
Feb 3, 2026
Merged

fix: download button not working in streaming mode #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions static/scripts/ocap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ async function loadOperation(op) {
// Get schema version from operation or default to 1
const schemaVersion = op.schemaVersion || 1;
console.log(`Loading operation ${op.id} using streaming mode (${op.storageFormat}, schema v${schemaVersion})`);
return processOpStreaming(op.id, op.storageFormat, schemaVersion);
return processOpStreaming(op.id, op.storageFormat, schemaVersion, op.filename);
}
// Fall back to legacy JSON loading
console.log(`Loading operation using legacy JSON mode`);
Expand Down Expand Up @@ -1075,7 +1075,8 @@ async function loadOperationByFilename(filename) {
function processOp (filepath, opRecord) {
console.log("Processing operation: (" + filepath + ")...");
const time = new Date();
fileName = filepath.substr(5, filepath.length);
// Strip "data/" prefix and .json extension since /file/:name endpoint adds .json.gz
fileName = filepath.substr(5, filepath.length).replace(/\.json$/, '');

let data;
return fetch(filepath)
Expand Down Expand Up @@ -1772,10 +1773,14 @@ async function getOperationFormat(operationId) {
* @param {number} schemaVersion - Schema version (default: 1)
* @returns {Promise<void>}
*/
async function processOpStreaming(operationId, format = 'protobuf', schemaVersion = 1) {
async function processOpStreaming(operationId, format = 'protobuf', schemaVersion = 1, operationFilename = null) {
console.log(`Processing operation (streaming mode): ${operationId} (format: ${format}, schema: v${schemaVersion})`);
const time = new Date();

// Set global fileName for download functionality
// Strip .json extension since /file/:name endpoint adds .json.gz
fileName = (operationFilename || operationId).replace(/\.json$/, '');

// Get versioned loader from registry
const loader = LoaderRegistry.getLoader(schemaVersion);

Expand Down
Loading