fix: download button not working in streaming mode#121
Merged
Conversation
The download button threw "ReferenceError: fileName is not defined" when using streaming mode because processOpStreaming didn't set the global fileName variable. Additionally, the filename stored in the database includes ".json" extension, but the /file/:name endpoint adds ".json.gz", causing double extension lookups. Now strips ".json" when setting fileName in both streaming and legacy modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReferenceError: fileName is not definedwhen clicking download button in streaming modeprocessOpStreamingand set the globalfileNamevariable.jsonextension from filename in both streaming and legacy modes to fix double extension issue (database storesfile.json, endpoint adds.json.gz)Test plan