Skip to content

WIP: get rid of module rec and functors by moving many types into types.ml#576

Draft
lefessan wants to merge 3 commits intoOCamlPro:nextfrom
lefessan:z-2023-04-14-all-in-types
Draft

WIP: get rid of module rec and functors by moving many types into types.ml#576
lefessan wants to merge 3 commits intoOCamlPro:nextfrom
lefessan:z-2023-04-14-all-in-types

Conversation

@lefessan
Copy link
Member

@lefessan lefessan commented Apr 15, 2023

Currently, the code of alt-ergo is hard to enter because it is a huge recursive mess, where all theories are functors with a Sig.SHOSTAK interface and they are all gathered together in the shostak.ml using a big module rec.

This patch is probably not intented to be merged at any point, but it might be interesting as it simplifies the code by removing this use of functors and module rec :

  • Types from symbols.ml, expr.ml and all theories are gathered together in a file types.ml (which makes it easier to understand what they are ...)
  • A shostak_pre.ml file exposes shostak.ml functions before they are available, to allow a huge recursion between modules. It exposes a set of refs, which are set from the shostak.ml file at the end.
  • Most of the changes are replacements of scopes changes to use Types instead of Symbols or Expr.

@lefessan lefessan marked this pull request as draft April 17, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant