WIP: get rid of module rec and functors by moving many types into types.ml#576
Draft
lefessan wants to merge 3 commits intoOCamlPro:nextfrom
Draft
WIP: get rid of module rec and functors by moving many types into types.ml#576lefessan wants to merge 3 commits intoOCamlPro:nextfrom
lefessan wants to merge 3 commits intoOCamlPro:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the code of alt-ergo is hard to enter because it is a huge recursive mess, where all theories are functors with a
Sig.SHOSTAKinterface and they are all gathered together in theshostak.mlusing a bigmodule rec.This patch is probably not intented to be merged at any point, but it might be interesting as it simplifies the code by removing this use of functors and module rec :
symbols.ml,expr.mland all theories are gathered together in a filetypes.ml(which makes it easier to understand what they are ...)shostak_pre.mlfile exposesshostak.mlfunctions before they are available, to allow a huge recursion between modules. It exposes a set of refs, which are set from theshostak.mlfile at the end.Typesinstead ofSymbolsorExpr.