Conversation
Signed-off-by: Peter Colberg <peter.colberg@altera.com>
Signed-off-by: Peter Colberg <peter.colberg@altera.com>
Signed-off-by: Peter Colberg <peter.colberg@altera.com>
fpgamatt
previously approved these changes
Jan 16, 2025
Reuse of the same artifact name is unsupported in upload-artifact@v4. Signed-off-by: Peter Colberg <peter.colberg@altera.com>
Contributor
Author
|
coding-style (c) fails due to |
Signed-off-by: Peter Colberg <peter.colberg@altera.com>
fpgamatt
reviewed
Jan 16, 2025
scripts/cover.sh
Outdated
|
|
||
| lcov --directory . --zerocounters | ||
| lcov -c -i -d . -o coverage.base | ||
| lcov -c -i -d . -o coverage.base --ignore-errors mismatch |
Contributor
There was a problem hiding this comment.
do you need 'mismatch,mismatch' ?
Contributor
Author
There was a problem hiding this comment.
The work-around seems to pass, but now a unit test is failing due to a newer Python version. The underlying cause is that the workflows default to the latest Ubuntu version, which changed from 22.04 to 24.04 recently. I have now specified the exact version in the workflows, which allows for an orderly transition to Ubuntu 24.04.
The GitHub hosted runners now default to Ubuntu 24.04, which results in multiple, smaller failures in the C/C++ build and test workflow. Signed-off-by: Peter Colberg <peter.colberg@altera.com>
pcolberg
force-pushed
the
pcolberg/actions
branch
from
aa2890e to
c6dea9c
Compare
Contributor
Author
This expectedly failed again. We could use the version shipped by the linux-headers package. |
Contributor
|
I think using the one included in the linux-headers package makes sense. |
pcolberg
force-pushed
the
pcolberg/actions
branch
from
cf514ff to
dcd84aa
Compare
checkpatch.pl may fail to download with HTTP 429 Too Many Requests. Signed-off-by: Peter Colberg <peter.colberg@altera.com>
pcolberg
force-pushed
the
pcolberg/actions
branch
from
dcd84aa to
e9b983b
Compare
fpgamatt
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See, e.g., Deprecation notice: v3 of the artifact actions.